Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2959713002: Remove more dead code (Closed)

Created:
3 years, 5 months ago by Brian Wilkerson
Modified:
3 years, 5 months ago
Reviewers:
devoncarew, scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1438 lines) Patch
D pkg/analysis_server/lib/src/analysis_manager.dart View 1 chunk +0 lines, -139 lines 0 comments Download
D pkg/analysis_server/lib/src/channel/web_socket_channel.dart View 1 chunk +0 lines, -139 lines 0 comments Download
D pkg/analysis_server/lib/src/provisional/refactoring/refactoring_core.dart View 1 chunk +0 lines, -102 lines 0 comments Download
D pkg/analysis_server/lib/src/services/correction/source_range.dart View 1 chunk +0 lines, -87 lines 0 comments Download
D pkg/analysis_server/lib/src/source/caching_pub_package_map_provider.dart View 1 chunk +0 lines, -258 lines 0 comments Download
D pkg/analysis_server/lib/src/utilities/average.dart View 1 chunk +0 lines, -28 lines 0 comments Download
M pkg/analysis_server/test/channel/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download
D pkg/analysis_server/test/channel/web_socket_channel_test.dart View 1 chunk +0 lines, -154 lines 0 comments Download
D pkg/analysis_server/test/services/correction/source_range_test.dart View 1 chunk +0 lines, -116 lines 0 comments Download
M pkg/analysis_server/test/services/correction/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download
D pkg/analysis_server/test/source/caching_put_package_map_provider_test.dart View 1 chunk +0 lines, -399 lines 0 comments Download
D pkg/analysis_server/test/source/test_all.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M pkg/analysis_server/test/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
3 years, 5 months ago (2017-06-26 13:13:05 UTC) #2
devoncarew
lgtm
3 years, 5 months ago (2017-06-26 13:29:46 UTC) #3
Brian Wilkerson
Committed patchset #1 (id:1) manually as c9dce504cc787af43319a28c250b446e44ad505a (presubmit successful).
3 years, 5 months ago (2017-06-26 14:31:29 UTC) #5
scheglov
3 years, 5 months ago (2017-06-26 19:43:58 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698