Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Issue 2959683002: Add compile_from_dill_fast_startup_test (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -201 lines) Patch
M pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart View 1 chunk +1 line, -0 lines 0 comments Download
A tests/compiler/dart2js/kernel/compile_from_dill_fast_startup_test.dart View 1 1 chunk +68 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test.dart View 1 3 chunks +6 lines, -143 lines 0 comments Download
A + tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart View 1 6 chunks +15 lines, -57 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 5 months ago (2017-06-26 11:17:18 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 5 months ago (2017-06-26 17:23:41 UTC) #3
Johnni Winther
3 years, 5 months ago (2017-06-27 07:59:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
07b0f45181bfcc0ac696c9e357dfc86fcc0c789b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698