Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 295943003: No longer checking 1080p in QtKit for WebRTC webcam tests. (Closed)

Created:
6 years, 7 months ago by phoglund_chromium
Modified:
6 years, 7 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Visibility:
Public.

Description

No longer checking 1080p in QtKit for WebRTC webcam tests. QtKit doesn't support 1080p, which I found out when I enabled our C920- equipped mac bot. Therefore we will no longer try to test that. Also temporarily disabling QVGA for qtkit since it incorrectly acquires 320x180 rather than 320x240. BUG=375185 TBR=tommi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271684

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M chrome/browser/media/chrome_webrtc_webcam_browsertest.cc View 2 chunks +19 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
phoglund_chromium
6 years, 7 months ago (2014-05-20 09:48:19 UTC) #1
perkj_chrome
lgtm
6 years, 7 months ago (2014-05-20 12:23:47 UTC) #2
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 7 months ago (2014-05-20 12:25:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/295943003/1
6 years, 7 months ago (2014-05-20 12:25:50 UTC) #4
phoglund_chromium
Oh right Per, you're not an OWNER there. Tommi, please take a look.
6 years, 7 months ago (2014-05-20 13:10:30 UTC) #5
phoglund_chromium
The CQ bit was unchecked by phoglund@chromium.org
6 years, 7 months ago (2014-05-20 13:10:38 UTC) #6
phoglund_chromium
The CQ bit was checked by phoglund@chromium.org
6 years, 7 months ago (2014-05-20 13:11:00 UTC) #7
tommi (sloooow) - chröme
rs lgtm
6 years, 7 months ago (2014-05-20 13:11:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phoglund@chromium.org/295943003/1
6 years, 7 months ago (2014-05-20 13:12:01 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 17:25:42 UTC) #10
Message was sent while issue was closed.
Change committed as 271684

Powered by Google App Engine
This is Rietveld 408576698