Multi-Profile in Files.app: always mount per-profile "Downloads" folder.

Multi-Profile in Files.app: always mount per-profile "Downloads" folder.

Now the multi-profile feature is turned on by default.
Files.app also always mounts per-profile separated "Downloads"
folder even in the test environment.

BUG=375131
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272370

[hirono, 2014-05-20 06:56:24]

Thank you! lgtm!

[hirono, 2014-05-20 06:56:24]

Thank you! lgtm!

[kinaba, 2014-05-20 06:57:02]

The CQ bit was checked by kinaba@chromium.org

[commit-bot: I haz the power, 2014-05-20 06:57:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kinaba@chromium.org/295943002/1

[commit-bot: I haz the power, 2014-05-20 10:47:01]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-20 12:06:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-20 12:06:59]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[kinaba, 2014-05-20 12:44:46]

The CQ bit was checked by kinaba@chromium.org

[commit-bot: I haz the power, 2014-05-20 12:44:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kinaba@chromium.org/295943002/1

[commit-bot: I haz the power, 2014-05-20 13:57:16]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[commit-bot: I haz the power, 2014-05-20 15:11:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-20 15:11:05]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[kinaba, 2014-05-21 01:14:49]

The CQ bit was checked by kinaba@chromium.org

[commit-bot: I haz the power, 2014-05-21 01:16:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kinaba@chromium.org/295943002/1

[commit-bot: I haz the power, 2014-05-21 02:34:25]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[kinaba, 2014-05-21 02:38:45]

On 2014/05/21 02:34:25, I haz the power (commit-bot) wrote:
> FYI, CQ is re-trying this CL (attempt #1).
> Please consider checking whether the failures are real,
> and report flakes to mailto:chrome-troopers@google.com.
> The failing builders are:
>   linux_chromium_chromeos_rel on tryserver.chromium
>
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

Ug. The test failure looks to be a real one. I'll take a look tomorrow.

[kinaba, 2014-05-21 02:38:51]

The CQ bit was unchecked by kinaba@chromium.org

[kinaba, 2014-05-22 03:24:10]

@hirono, could you take another look?

I revived the fallback to the host Downloads directory for the primary profile
only from two reasons:
(1) For fixing some tests that were expecting that preference migration is not
happening during the test.
(2) For keeping the ease of debugging (it is still easier to import arbitrary
files to the test environment).

[hirono, 2014-05-22 03:46:47]

On 2014/05/22 03:24:10, kinaba wrote:
> @hirono, could you take another look?
> 
> I revived the fallback to the host Downloads directory for the primary profile
> only from two reasons:
> (1) For fixing some tests that were expecting that preference migration is not
> happening during the test.
> (2) For keeping the ease of debugging (it is still easier to import arbitrary
> files to the test environment).

still lgtm!

[kinaba, 2014-05-22 03:53:13]

The CQ bit was checked by kinaba@chromium.org

[commit-bot: I haz the power, 2014-05-22 03:53:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kinaba@chromium.org/295943002/20001

[commit-bot: I haz the power, 2014-05-22 13:36:30]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-05-22 13:38:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 13:38:36]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[kinaba, 2014-05-22 13:39:53]

The CQ bit was checked by kinaba@chromium.org

[commit-bot: I haz the power, 2014-05-22 13:40:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kinaba@chromium.org/295943002/20001

[commit-bot: I haz the power, 2014-05-22 13:43:36]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-05-22 13:45:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 13:45:30]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[kinaba, 2014-05-22 13:57:00]

The CQ bit was checked by kinaba@chromium.org

[commit-bot: I haz the power, 2014-05-22 13:58:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kinaba@chromium.org/295943002/20001

[commit-bot: I haz the power, 2014-05-22 14:01:47]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-05-22 14:03:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 14:03:51]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[kinaba, 2014-05-22 23:53:47]

The CQ bit was checked by kinaba@chromium.org

[commit-bot: I haz the power, 2014-05-22 23:55:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kinaba@chromium.org/295943002/20001

[commit-bot: I haz the power, 2014-05-22 23:57:33]

Change committed as 272370