Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 295933017: Add base::mac::ScopedMachPort::release() (Closed)

Created:
6 years, 7 months ago by Mark Mentovai
Modified:
6 years, 7 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Add base::mac::ScopedMachPort::release(). Most of our other existing scopers have this method. It allows the scoper to "give up" its ownership claim. R=thakis@chromium.org, thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272956

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M base/mac/scoped_mach_port.h View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
6 years, 7 months ago (2014-05-23 01:57:11 UTC) #1
Nico
lgtm
6 years, 7 months ago (2014-05-23 23:09:17 UTC) #2
Mark Mentovai
6 years, 7 months ago (2014-05-27 12:58:49 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r272956 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698