Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 295933013: Some build changes for nacl on Android (Closed)

Created:
6 years, 7 months ago by sehr
Modified:
6 years, 7 months ago
CC:
chromium-reviews, piman+watch_chromium.org, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Some build changes for nacl on Android 1) Use TOOLCHAIN_OS rather than OS for package names 2) gpu_nacl.gyp shouldn't include trusted code test dependencies. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3032 R=bbudge@chromium.org, bradnelson@google.com, piman@chromium.org, sievers@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272345

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -21 lines) Patch
M gpu/gpu.gyp View 1 chunk +11 lines, -0 lines 0 comments Download
M gpu/gpu_common.gypi View 1 chunk +0 lines, -17 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_support_extension.gyp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
sehr
Another couple of small steps toward getting nacl to run in clank. PTAL.
6 years, 7 months ago (2014-05-22 15:13:48 UTC) #1
bbudge
rubberstamp lgtm
6 years, 7 months ago (2014-05-22 17:13:24 UTC) #2
bradn
lgtm
6 years, 7 months ago (2014-05-22 17:14:55 UTC) #3
sehr
The CQ bit was checked by sehr@chromium.org
6 years, 7 months ago (2014-05-22 19:26:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sehr@chromium.org/295933013/1
6 years, 7 months ago (2014-05-22 19:28:42 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 19:53:34 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 20:00:37 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/69310)
6 years, 7 months ago (2014-05-22 20:00:37 UTC) #8
sehr
piman, sievers, I need an OWNER lgtm for this CL. If you please, kind sirs. ...
6 years, 7 months ago (2014-05-22 21:22:44 UTC) #9
no sievers
lgtm
6 years, 7 months ago (2014-05-22 21:24:46 UTC) #10
piman
lgtm
6 years, 7 months ago (2014-05-22 21:55:25 UTC) #11
sehr
6 years, 7 months ago (2014-05-22 22:19:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 manually as r272345 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698