Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 295933011: Fixed transparent app windows on Windows. (Closed)

Created:
6 years, 7 months ago by benwells
Modified:
6 years, 7 months ago
Reviewers:
calamity
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Fixed transparent app windows on Windows. These were broken due to the WS_CAPTION style always being applied. Now the style is not applied if the window has transparency enabled. BUG=373541 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272219

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/views/apps/chrome_native_app_window_views_win.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
benwells
6 years, 7 months ago (2014-05-22 05:40:56 UTC) #1
calamity
lgtm
6 years, 7 months ago (2014-05-22 07:55:02 UTC) #2
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 7 months ago (2014-05-22 08:03:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/295933011/1
6 years, 7 months ago (2014-05-22 08:05:47 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-22 17:33:26 UTC) #5
Message was sent while issue was closed.
Change committed as 272219

Powered by Google App Engine
This is Rietveld 408576698