Issue 295933006: dart2dart: Introduce compound assignment and prefix increment in dart_codegen.

Issue 295933006: dart2dart: Introduce compound assignment and prefix increment in dart_codegen. (Closed)

Created:
6 years, 7 months ago by asgerf

Modified:
6 years, 7 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

dart2dart: Introduce compound assignment and prefix increment in dart_codegen. Rewrite x = x + E ==> x += E. Rewrite x += 1 ==> ++x Currently, this never clicks for variables because are still in pseudo-SSA form, but it clicks for fields and index assignemnts. BUG= R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=36681

Patch Set 1 #

Total comments: 2

Patch Set 2 : Check for +/- operator on increment #

Patch Set 3 : SVN rebase #

Patch Set 4 : SVN rebase #

Patch Set 5 : Added test case #

Patch Set 6 : SVN rebase #

Patch Set 7 : Set element on Send node for increment expressions #

Patch Set 8 : SVN rebase #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+211 lines, -35 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/dart_backend/dart_codegen.dart	View	1 2 3 4 5 6	3 chunks	+47 lines, -7 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart_backend/dart_printer.dart	View		7 chunks	+36 lines, -22 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart_backend/dart_tree_printer.dart	View	1 2 3 4 5 6	4 chunks	+9 lines, -6 lines	0 comments	Download
A	tests/language/rewrite_compound_assign_test.dart	View	1 2 3 4	1 chunk	+119 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

LGTM. https://codereview.chromium.org/295933006/diff/1/sdk/lib/_internal/compiler/implementation/dart_backend/dart_codegen.dart File sdk/lib/_internal/compiler/implementation/dart_backend/dart_codegen.dart (right): https://codereview.chromium.org/295933006/diff/1/sdk/lib/_internal/compiler/implementation/dart_backend/dart_codegen.dart#newcode142 sdk/lib/_internal/compiler/implementation/dart_backend/dart_codegen.dart:142: if (rightOperand is Literal && rightOperand.value.isOne) { And ...

6 years, 7 months ago (2014-05-21 13:20:57 UTC) #2

asgerf

https://codereview.chromium.org/295933006/diff/1/sdk/lib/_internal/compiler/implementation/dart_backend/dart_codegen.dart File sdk/lib/_internal/compiler/implementation/dart_backend/dart_codegen.dart (right): https://codereview.chromium.org/295933006/diff/1/sdk/lib/_internal/compiler/implementation/dart_backend/dart_codegen.dart#newcode142 sdk/lib/_internal/compiler/implementation/dart_backend/dart_codegen.dart:142: if (rightOperand is Literal && rightOperand.value.isOne) { On 2014/05/21 ...

6 years, 7 months ago (2014-05-21 13:25:06 UTC) #3

asgerf

6 years, 7 months ago (2014-05-27 14:12:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #8 manually as r36681 (presubmit successful).

Expand Messages | Collapse Messages