Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1131)

Issue 295933002: [fsp] Do not crash on an invalid modification time. (Closed)

Created:
6 years, 7 months ago by mtomasz
Modified:
6 years, 7 months ago
Reviewers:
hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

[fsp] Do not crash on an invalid modification time. Before, if a modification time was InvalidDate, then it caused a crash on a DCHECK converting a string date to base::Time. Providers may return an incorrect date, and we shouldn't crash. This patch resolves this issue by removing the DCHECK and passing the invalid date to fileapi. TEST=unit_test: *FileSystemProvider*GetMetadata* BUG=248427 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271959

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -8 lines) Patch
M chrome/browser/chromeos/file_system_provider/operations/get_metadata.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/get_metadata/test.js View 1 6 chunks +42 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mtomasz
@hirono: PTAL. The test case is copy paste. Thanks.
6 years, 7 months ago (2014-05-20 04:33:30 UTC) #1
hirono
lgtm with a nit. https://codereview.chromium.org/295933002/diff/1/chrome/test/data/extensions/api_test/file_system_provider/get_metadata/test.js File chrome/test/data/extensions/api_test/file_system_provider/get_metadata/test.js (right): https://codereview.chromium.org/295933002/diff/1/chrome/test/data/extensions/api_test/file_system_provider/get_metadata/test.js#newcode152 chrome/test/data/extensions/api_test/file_system_provider/get_metadata/test.js:152: var onSuccess = chrome.test.callbackPass(function() {}); ...
6 years, 7 months ago (2014-05-20 04:39:56 UTC) #2
mtomasz
https://codereview.chromium.org/295933002/diff/1/chrome/test/data/extensions/api_test/file_system_provider/get_metadata/test.js File chrome/test/data/extensions/api_test/file_system_provider/get_metadata/test.js (right): https://codereview.chromium.org/295933002/diff/1/chrome/test/data/extensions/api_test/file_system_provider/get_metadata/test.js#newcode152 chrome/test/data/extensions/api_test/file_system_provider/get_metadata/test.js:152: var onSuccess = chrome.test.callbackPass(function() {}); On 2014/05/20 04:39:56, hirono ...
6 years, 7 months ago (2014-05-21 01:39:59 UTC) #3
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 7 months ago (2014-05-21 01:40:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/295933002/20001
6 years, 7 months ago (2014-05-21 01:41:31 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-21 07:45:36 UTC) #6
mtomasz
The CQ bit was unchecked by mtomasz@chromium.org
6 years, 7 months ago (2014-05-21 14:41:20 UTC) #7
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 7 months ago (2014-05-21 14:41:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/295933002/20001
6 years, 7 months ago (2014-05-21 19:57:35 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 20:17:44 UTC) #10
Message was sent while issue was closed.
Change committed as 271959

Powered by Google App Engine
This is Rietveld 408576698