Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: tools/licenses.py

Issue 2959303002: [Cronet] Use gn desc to find third party licenses on Android. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/android/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/licenses.py
diff --git a/tools/licenses.py b/tools/licenses.py
index 9f33ffb8450ef0e440658c997302b3c55a904bf1..d4767fdd4c2f619f98389779df512d2b3d9332d2 100755
--- a/tools/licenses.py
+++ b/tools/licenses.py
@@ -493,7 +493,8 @@ def GetThirdPartyDepsFromGNDepsOutput(gn_deps):
third_party_deps = set()
for build_dep in gn_deps.split():
m = re.search(r'^(.+/third_party/[^/]+)/(.+/)?BUILD\.gn$', build_dep)
- if m:
+ # TODO(phajdan): Consider using PRUNE_PATHS to filter unwanted deps.
Paweł Hajdan Jr. 2017/06/30 07:16:05 Why does this TODO add me? It should add the perso
mef 2017/06/30 12:38:40 I'll be happy to leave it as is or use PRUNE_PATHS
mef 2017/06/30 14:31:45 I've played with relpath and PRUNE_PATHS and it lo
+ if m and not os.path.join("secondary", "third_party") in build_dep:
third_party_deps.add(m.group(1))
return third_party_deps
« no previous file with comments | « components/cronet/android/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698