[iOS] Add EG tests for the Keyboard accessory view.

ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller_egtest.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <AVFoundation/AVFoundation.h>
 #import <EarlGrey/EarlGrey.h>
 #import <UIKit/UIKit.h>
 
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/strings/grit/components_strings.h"
 #include "components/version_info/version_info.h"
 #import "ios/chrome/app/main_controller.h"
 #include "ios/chrome/browser/chrome_switches.h"
+#include "ios/chrome/browser/experimental_flags.h"
 #import "ios/chrome/browser/ui/browser_view_controller.h"
 #import "ios/chrome/browser/ui/commands/generic_chrome_command.h"
 #include "ios/chrome/browser/ui/commands/ios_command_ids.h"
 #include "ios/chrome/browser/ui/icons/chrome_icon.h"
 #include "ios/chrome/browser/ui/qr_scanner/camera_controller.h"
 #include "ios/chrome/browser/ui/qr_scanner/qr_scanner_view.h"
 #include "ios/chrome/browser/ui/qr_scanner/qr_scanner_view_controller.h"
 #include "ios/chrome/browser/ui/toolbar/web_toolbar_controller.h"
 #include "ios/chrome/grit/ios_chromium_strings.h"
 #include "ios/chrome/grit/ios_strings.h"
@@ skipping 79 matching lines @@
   return ButtonWithAccessibilityLabelId(IDS_ACCNAME_BACK);
 }
 
 // Returns the GREYMatcher for the Cancel button to dismiss a UIAlertController.
 id<GREYMatcher> DialogCancelButton() {
   return grey_allOf(
       grey_text(l10n_util::GetNSString(IDS_IOS_QR_SCANNER_ALERT_CANCEL)),
       grey_accessibilityTrait(UIAccessibilityTraitStaticText), nil);
 }
 
-// Opens the QR Scanner view using a command.
-// TODO(crbug.com/629776): Replace the command call with a UI action.
-void ShowQRScannerWithCommand() {
-  GenericChromeCommand* command =
-      [[GenericChromeCommand alloc] initWithTag:IDC_SHOW_QR_SCANNER];
-  chrome_test_util::RunCommandWithActiveViewController(command);
+// Opens the QR Scanner view.
+void ShowQRScanner() {
+  if (experimental_flags::IsKeyboardAccessoryViewWithCameraSearchEnabled()) {

[justincohen, 2017/06/28 21:20:53]

Is this enabled by default?  

[jif, 2017/06/29 15:57:04]

It is.
I was thinking of removing the "else" once
|IsKeyboardAccessoryViewWithCameraSearchEnabled| is removed.

[justincohen, 2017/06/29 15:58:24]

If you think it's reasonable, maybe add a comment with a bug to track the
removal?

[jif, 2017/06/29 18:29:26]

Done.

+    // Tap the omnibox to get the keyboard accessory view to show up.
+    id<GREYMatcher> locationbarButton = grey_allOf(
+        grey_accessibilityLabel(l10n_util::GetNSString(IDS_OMNIBOX_EMPTY_HINT)),
+        grey_minimumVisiblePercent(0.2), nil);
+    [[EarlGrey selectElementWithMatcher:locationbarButton]
+        assertWithMatcher:grey_text(@"Search or type URL")];
+    [[EarlGrey selectElementWithMatcher:locationbarButton]
+        performAction:grey_tap()];
+
+    // Tap the QR Code scanner button in the keyboard accessory view.
+    id<GREYMatcher> matcher =
+        grey_allOf(grey_accessibilityLabel(@"QR code Search"),
+                   grey_kindOfClass([UIButton class]), nil);
+
+    [[EarlGrey selectElementWithMatcher:matcher] performAction:grey_tap()];
+  } else {
+    GenericChromeCommand* command =
+        [[GenericChromeCommand alloc] initWithTag:IDC_SHOW_QR_SCANNER];
+    chrome_test_util::RunCommandWithActiveViewController(command);
+  }
 }
 
 // Taps the |button|.
 void TapButton(id<GREYMatcher> button) {
   [[EarlGrey selectElementWithMatcher:button] performAction:grey_tap()];
 }
 
 // Appends the given |editText| to the |text| already in the omnibox and presses
 // the keyboard return key.
 void EditOmniboxTextAndTapKeyboardReturn(std::string text, NSString* editText) {
@@ skipping 114 matching lines @@
 // Presents the QR Scanner with a command, waits for it to be displayed, and
 // checks if all its views and buttons are visible. Checks that no alerts are
 // presented.
 - (void)showQRScannerAndCheckLayoutWithCameraMock:(id)mock {
   UIViewController* bvc = [self currentBVC];
   [self assertModalOfClass:[QRScannerViewController class]
           isNotPresentedBy:bvc];
   [self assertModalOfClass:[UIAlertController class] isNotPresentedBy:bvc];
 
   [self addCameraControllerInitializationExpectations:mock];
-  ShowQRScannerWithCommand();
+  ShowQRScanner();
   [self waitForModalOfClass:[QRScannerViewController class] toAppearAbove:bvc];
   [self assertQRScannerUIIsVisibleWithTorch:NO];
   [self assertModalOfClass:[UIAlertController class]
           isNotPresentedBy:[bvc presentedViewController]];
   [self assertModalOfClass:[UIAlertController class] isNotPresentedBy:bvc];
 }
 
 // Closes the QR scanner by tapping the close button and waits for it to
 // disappear.
 - (void)closeQRScannerWithCameraMock:(id)mock {
@@ skipping 360 matching lines @@
 
   UIViewController* bvc = [self currentBVC];
   [self assertModalOfClass:[QRScannerViewController class]
           isNotPresentedBy:bvc];
   [self assertModalOfClass:[UIAlertController class] isNotPresentedBy:bvc];
   id cameraControllerMock =
       [self getCameraControllerMockWithAuthorizationStatus:
                 AVAuthorizationStatusDenied];
   [self swizzleCameraController:cameraControllerMock];
 
-  ShowQRScannerWithCommand();
+  ShowQRScanner();
   [self assertModalOfClass:[QRScannerViewController class]
           isNotPresentedBy:bvc];
   [self waitForModalOfClass:[UIAlertController class] toAppearAbove:bvc];
 
   TapButton(DialogCancelButton());
   [self waitForModalOfClass:[UIAlertController class] toDisappearFromAbove:bvc];
 }
 
 // Tests that a UIAlertController is presented by the QRScannerViewController if
 // the camera state changes after the QRScannerViewController is presented.
@@ skipping 166 matching lines @@
 // Test that the correct page is loaded if the scanner result is a search query
 // which is then manually edited.
 - (void)testReceivingQRScannerSearchQueryResultAndEditingTheQuery {
   [self swizzleWebToolbarControllerLoadGURLFromLocationBar:_testQueryEdited];
   [self doTestReceivingResult:kTestQuery
                      response:kTestQueryEditedResponse
                          edit:@"\bedited"];
 }
 
 @end