Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 295923002: Use tighter typing for RenderTextFragment::firstLetter() (Closed)

Created:
6 years, 7 months ago by Inactive
Modified:
6 years, 7 months ago
Reviewers:
pdr., esprehn
CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-rendering, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, zoltan1, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, rune+blink
Visibility:
Public.

Description

Use tighter typing for RenderTextFragment::firstLetter() Use tighter typing for RenderTextFragment::firstLetter(). We can use a RenderBoxModelObject* instead of a simpler RenderObject*. There is no performance impact at this point as RenderBoxModelObject does not have firstChild() / lastChild() and RenderObject's slowFirstChild() / slowLastChild() are still being called. R=esprehn@chromium.org, pdr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174388

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M Source/core/editing/TextIterator.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderTextFragment.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 7 months ago (2014-05-20 05:23:33 UTC) #1
pdr.
On 2014/05/20 05:23:33, Chris Dumez wrote: LGTM
6 years, 7 months ago (2014-05-20 17:06:57 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 7 months ago (2014-05-20 17:07:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/295923002/1
6 years, 7 months ago (2014-05-20 17:07:53 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 17:22:16 UTC) #5
Message was sent while issue was closed.
Change committed as 174388

Powered by Google App Engine
This is Rietveld 408576698