Issue 295923002: Use tighter typing for RenderTextFragment::firstLetter()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 295923002: Use tighter typing for RenderTextFragment::firstLetter() (Closed)

Created:
6 years, 7 months ago by Inactive

Modified:
6 years, 7 months ago

Reviewers:
pdr., esprehn

CC:
blink-reviews, caseq+blink_chromium.org, blink-reviews-rendering, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, zoltan1, eae+blinkwatch, yurys+blink_chromium.org, lushnikov+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, jchaffraix+rendering, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Use tighter typing for RenderTextFragment::firstLetter() Use tighter typing for RenderTextFragment::firstLetter(). We can use a RenderBoxModelObject* instead of a simpler RenderObject*. There is no performance impact at this point as RenderBoxModelObject does not have firstChild() / lastChild() and RenderObject's slowFirstChild() / slowLastChild() are still being called. R=esprehn@chromium.org, pdr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174388

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -8 lines)			Patch
M	Source/core/editing/TextIterator.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/inspector/InspectorCSSAgent.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/RenderBlock.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/rendering/RenderTextFragment.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/295923002/1

6 years, 7 months ago (2014-05-20 17:07:53 UTC) #4

Message was sent while issue was closed.

Change committed as 174388

Expand Messages | Collapse Messages