Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2959213002: Fix for missing interface targets when not in strong mode. (Closed)

Created:
3 years, 5 months ago by Paul Berry
Modified:
3 years, 5 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for missing interface targets when not in strong mode. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/37a5c124ee5056a674abf651defb852ed81537ea

Patch Set 1 #

Patch Set 2 : Update expectation files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -112 lines) Patch
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 1 chunk +6 lines, -2 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_index_super.dart.direct.expect View 1 1 chunk +14 lines, -14 lines 0 comments Download
M pkg/front_end/testcases/inference/infer_assign_to_index_super_upwards.dart.direct.expect View 1 9 chunks +84 lines, -84 lines 0 comments Download
M pkg/front_end/testcases/super_rasta_copy.dart.direct.expect View 1 6 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 5 months ago (2017-06-28 18:06:25 UTC) #2
scheglov
LGTM
3 years, 5 months ago (2017-06-28 18:10:38 UTC) #3
Paul Berry
3 years, 5 months ago (2017-06-28 18:23:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
37a5c124ee5056a674abf651defb852ed81537ea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698