Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: net/cookies/canonical_cookie.cc

Issue 2959123002: Allow paths constructed from URLs rather as well as cookie attributes. (Closed)
Patch Set: Remove test for space in path--GURL escapes those. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/cookies/canonical_cookie_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cookies/canonical_cookie.cc
diff --git a/net/cookies/canonical_cookie.cc b/net/cookies/canonical_cookie.cc
index 4372bde3450fe54a9bf5b9fa684d6181626f443c..9cf9f7aef73df0ac9cb68613a82f3baf6ce8fd96 100644
--- a/net/cookies/canonical_cookie.cc
+++ b/net/cookies/canonical_cookie.cc
@@ -404,14 +404,12 @@ bool CanonicalCookie::FullCompare(const CanonicalCookie& other) const {
}
bool CanonicalCookie::IsCanonical() const {
- // Not checking domain against ParsedCookie as it may have come purely
- // from the URL.
+ // Not checking domain or path against ParsedCookie as it may have
+ // come purely from the URL.
if (ParsedCookie::ParseTokenString(name_) != name_ ||
ParsedCookie::ParseValueString(value_) != value_ ||
- ParsedCookie::ParseValueString(path_) != path_ ||
!ParsedCookie::IsValidCookieAttributeValue(name_) ||
- !ParsedCookie::IsValidCookieAttributeValue(value_) ||
- !ParsedCookie::IsValidCookieAttributeValue(path_)) {
+ !ParsedCookie::IsValidCookieAttributeValue(value_)) {
return false;
}
« no previous file with comments | « no previous file | net/cookies/canonical_cookie_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698