Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 295903006: Retain the menu models in the class along with the menu runner. (Closed)

Created:
6 years, 7 months ago by dmazzoni
Modified:
6 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Retain the menu models in the class along with the menu runner. The issue was that we were posting an asynchronous accessibility event on the menu item view, and the menu item view was still around after the menu closed (just hidden, and owned by the menu runner), but the menu item view's delegate (the menu model adapter) had gone out of scope. BUG=327510 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271961

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M ash/shelf/shelf_view.h View 3 chunks +10 lines, -3 lines 0 comments Download
M ash/shelf/shelf_view.cc View 2 chunks +8 lines, -13 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
dmazzoni
6 years, 7 months ago (2014-05-20 23:07:48 UTC) #1
sky
LGTM
6 years, 7 months ago (2014-05-20 23:38:53 UTC) #2
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 7 months ago (2014-05-21 04:47:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/295903006/1
6 years, 7 months ago (2014-05-21 04:47:56 UTC) #4
dmazzoni
The CQ bit was unchecked by dmazzoni@chromium.org
6 years, 7 months ago (2014-05-21 17:22:23 UTC) #5
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 7 months ago (2014-05-21 17:42:45 UTC) #6
dmazzoni
The CQ bit was unchecked by dmazzoni@chromium.org
6 years, 7 months ago (2014-05-21 17:43:00 UTC) #7
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 7 months ago (2014-05-21 17:43:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/295903006/1
6 years, 7 months ago (2014-05-21 19:57:43 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-21 20:27:04 UTC) #10
Message was sent while issue was closed.
Change committed as 271961

Powered by Google App Engine
This is Rietveld 408576698