MD-Settings: Create tests for edit options in Credit Cards.

chrome/test/data/webui/settings/settings_autofill_section_browsertest.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Runs the Polymer Autofill Settings tests. */
 
 /** @const {string} Path to root from chrome/test/data/webui/settings/. */
 var ROOT_PATH = '../../../../../';
 
 // Polymer BrowserTest fixture.
@@ skipping 415 matching lines @@
 
         creditCardDialog.addEventListener('close', function() {
           // Test is |done| in a timeout in order to ensure that
           // 'save-credit-card' is NOT fired after this test.
           window.setTimeout(done, 100);
         });
 
         MockInteractions.tap(creditCardDialog.$.cancelButton);
       });
     });
+
+    test('verifyLocalCreditCardMenu', function() {
+      var creditCards = [FakeDataMaker.addressEntry()];

[dpapad, 2017/06/27 22:00:36]

Shouldn't this be calling creditCardEntry()?

Also, is there a reason to put this in an array here? Why not just wrap it in an
array at line 444, before passing it to createAutofillSection_? Same for next
test.

[hcarmona, 2017/06/27 22:26:41]

Yes, good catch.
Sounds good, updated.

+
+      // When CC is local, |isCached| will be undefined.
+      creditCards[0].metadata.isLocal = true;
+      creditCards[0].metadata.isCached = undefined;
+
+      var section = self.createAutofillSection_([], creditCards);
+      assertTrue(!!section);

[dpapad, 2017/06/27 22:00:36]

Is this assertion necessary? Can it ever fail?

[hcarmona, 2017/06/27 22:26:41]

Removed here and elsewhere.

+      var creditCardList = section.$.creditCardList;
+      assertTrue(!!creditCardList);
+      assertEquals(2, creditCardList.children.length);  // Template + Row.

[dpapad, 2017/06/27 22:00:36]

How about the following?
assertEquals(1, creditCardList.querySelectorAll('.list-item').length);

This avoids having to account for the <template> child (which is an
implementation detail of dom-repeat).

[hcarmona, 2017/06/27 22:26:41]

Done.

+      var row = creditCardList.children[0];
+
+      // Local CCs will show the overflow menu.
+      assertFalse(!!row.querySelector('#remoteCreditCardLink'));
+      var menuButton = row.querySelector('#creditCardMenu')
+      assertTrue(!!menuButton);
+
+      menuButton.click();
+      Polymer.dom.flush();
+
+      var ccMenu = section.$.creditCardSharedMenu;

[dpapad, 2017/06/27 22:00:36]

Avoid non established abbreviations (per styleguide). Maybe just rename to
|menu| here since there is no ambiguity about which menu is referenced.

[hcarmona, 2017/06/27 22:26:41]

Done.

+
+      // Menu should have 2 options.
+      assertFalse(ccMenu.querySelector('#menuEditCreditCard').hidden);
+      assertFalse(ccMenu.querySelector('#menuRemoveCreditCard').hidden);
+      assertTrue(ccMenu.querySelector('#menuClearCreditCard').hidden);
+
+      ccMenu.close();
+      Polymer.dom.flush();
+    });
+
+    test('verifyCachedCreditCardMenu', function() {
+      var creditCards = [FakeDataMaker.addressEntry()];
+
+      creditCards[0].metadata.isLocal = false;
+      creditCards[0].metadata.isCached = true;
+
+      var section = self.createAutofillSection_([], creditCards);
+      assertTrue(!!section);
+      var creditCardList = section.$.creditCardList;
+      assertTrue(!!creditCardList);
+      assertEquals(2, creditCardList.children.length);  // Template + Row.
+      var row = creditCardList.children[0];
+
+      // Cached remote CCs will show overflow menu.
+      assertFalse(!!row.querySelector('#remoteCreditCardLink'));
+      var menuButton = row.querySelector('#creditCardMenu')
+      assertTrue(!!menuButton);
+
+      menuButton.click();
+      Polymer.dom.flush();
+
+      var ccMenu = section.$.creditCardSharedMenu;
+
+      // Menu should have 2 options.
+      assertFalse(ccMenu.querySelector('#menuEditCreditCard').hidden);
+      assertTrue(ccMenu.querySelector('#menuRemoveCreditCard').hidden);
+      assertFalse(ccMenu.querySelector('#menuClearCreditCard').hidden);
+
+      ccMenu.close();
+      Polymer.dom.flush();
+    });
+
+    test('verifyNotCachedCreditCardMenu', function() {
+      var creditCards = [FakeDataMaker.addressEntry()];
+
+      creditCards[0].metadata.isLocal = false;
+      creditCards[0].metadata.isCached = false;
+
+      var section = self.createAutofillSection_([], creditCards);
+      assertTrue(!!section);
+      var creditCardList = section.$.creditCardList;
+      assertTrue(!!creditCardList);
+      assertEquals(2, creditCardList.children.length);  // Template + Row.
+      var row = creditCardList.children[0];
+
+      // No overflow menu when not cached.
+      assertTrue(!!row.querySelector('#remoteCreditCardLink'));
+      assertFalse(!!row.querySelector('#creditCardMenu'));
+    });
   });
 
   mocha.run();
 });
 
 TEST_F('SettingsAutofillSectionBrowserTest', 'AddressTests', function() {
   var self = this;
 
 
   suite('AutofillSection', function() {
@@ skipping 508 matching lines @@
           assertEquals(city, cols[0].value);
           assertEquals(state, cols[1].value);
           assertEquals(zip, cols[2].value);
         });
       });
     });
   });
 
   mocha.run();
 });