Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5565)

Unified Diff: chrome/browser/engagement/important_sites_usage_counter_unittest.cc

Issue 2958943002: Remove references to DB thread from unit test.
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/engagement/important_sites_usage_counter_unittest.cc
diff --git a/chrome/browser/engagement/important_sites_usage_counter_unittest.cc b/chrome/browser/engagement/important_sites_usage_counter_unittest.cc
index 252221f19cb29923e18c6d7afaa02219d98d1056..c9278cf9b7bc1f5d28123bcca8a7ddce8353dbd7 100644
--- a/chrome/browser/engagement/important_sites_usage_counter_unittest.cc
+++ b/chrome/browser/engagement/important_sites_usage_counter_unittest.cc
@@ -9,6 +9,7 @@
#include "base/files/scoped_temp_dir.h"
#include "base/run_loop.h"
#include "base/test/histogram_tester.h"
+#include "base/threading/thread_task_runner_handle.h"
#include "chrome/browser/bookmarks/bookmark_model_factory.h"
#include "chrome/test/base/testing_profile.h"
#include "content/public/browser/browser_thread.h"
@@ -35,11 +36,10 @@ class ImportantSitesUsageCounterTest : public testing::Test {
TestingProfile* profile() { return &profile_; }
QuotaManager* CreateQuotaManager() {
- quota_manager_ = new QuotaManager(
- false, temp_dir_.GetPath(),
- BrowserThread::GetTaskRunnerForThread(BrowserThread::IO).get(),
- BrowserThread::GetTaskRunnerForThread(BrowserThread::DB).get(), nullptr,
- storage::GetQuotaSettingsFunc());
+ quota_manager_ = new QuotaManager(false, temp_dir_.GetPath(),
+ base::ThreadTaskRunnerHandle::Get(),
+ base::ThreadTaskRunnerHandle::Get(),
+ nullptr, storage::GetQuotaSettingsFunc());
return quota_manager_.get();
}
@@ -82,7 +82,7 @@ class ImportantSitesUsageCounterTest : public testing::Test {
const std::vector<ImportantDomainInfo>& domain_info() { return domain_info_; }
private:
- content::TestBrowserThreadBundle thread_bundle_;
+ content::TestBrowserThreadBundle thread_bundle;
fdoray 2017/06/27 13:28:56 Do not remove the trailing underscore.
TestingProfile profile_;
base::ScopedTempDir temp_dir_;
scoped_refptr<QuotaManager> quota_manager_;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698