Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 295893002: Cleanup various Windows installer/breakpad bits. (Closed)

Created:
6 years, 7 months ago by Lei Zhang
Modified:
6 years, 7 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Cleanup various Windows installer/breakpad bits. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271699

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -19 lines) Patch
M chrome/app/chrome_breakpad_client.cc View 1 2 3 4 chunks +8 lines, -11 lines 0 comments Download
M chrome/installer/util/google_update_settings.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/google_update_settings.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/installer/util/master_preferences_dummy.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
6 years, 7 months ago (2014-05-20 02:04:22 UTC) #1
grt (UTC plus 2)
lgtm
6 years, 7 months ago (2014-05-20 15:34:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/295893002/60001
6 years, 7 months ago (2014-05-20 15:34:29 UTC) #3
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 17:49:07 UTC) #4
Message was sent while issue was closed.
Change committed as 271699

Powered by Google App Engine
This is Rietveld 408576698