Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 2958833003: Allocate local variable holding type arguments in generic functions in Kernel. (Closed)

Created:
3 years, 5 months ago by regis
Modified:
3 years, 5 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allocate local variable holding type arguments in generic functions in Kernel. Capture instantiators when calling generic functions with uninstantiated type arguments. Add VM flag to generic functions tests that do not expect reification. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/d9cc3b0e67c907f5ab4f08b8c1da84288f06e1a8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -8 lines) Patch
M runtime/vm/compiler.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M runtime/vm/kernel_binary_flowgraph.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/vm/parser.cc View 3 chunks +21 lines, -3 lines 0 comments Download
M tests/language/generic_function_typedef_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/generic_method_types_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/generic_methods_new_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
3 years, 5 months ago (2017-06-27 20:24:26 UTC) #2
siva
lgtm
3 years, 5 months ago (2017-06-27 22:16:45 UTC) #3
regis
3 years, 5 months ago (2017-06-27 22:19:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d9cc3b0e67c907f5ab4f08b8c1da84288f06e1a8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698