content/browser/service_worker/service_worker_registration_unittest.cc - Issue 2958753003: Revert "Create ServiceWorkerProviderHost before starting worker"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_registration_unittest.cc

Issue 2958753003: Revert "Create ServiceWorkerProviderHost before starting worker" (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_registration_handle.h ('k') | content/browser/service_worker/service_worker_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_registration_unittest.cc

diff --git a/content/browser/service_worker/service_worker_registration_unittest.cc b/content/browser/service_worker/service_worker_registration_unittest.cc

index 7d943cd379f22809f0ca618001a3a80f46297374..444135eeaa4ff5f834487e1dace16bba4ddbe4f6 100644

--- a/content/browser/service_worker/service_worker_registration_unittest.cc

+++ b/content/browser/service_worker/service_worker_registration_unittest.cc

@@ -260,8 +260,6 @@ class ServiceWorkerActivationTest : public ServiceWorkerRegistrationTest {

helper_->mock_render_process_id(), 1 /* dummy provider_id */,

true /* is_parent_frame_secure */, context()->AsWeakPtr(),

&remote_endpoint_);

- DCHECK(remote_endpoint_.client_request()->is_pending());

- DCHECK(remote_endpoint_.host_ptr()->is_bound());

version_1->AddControllee(host_.get());

// Give the active version an in-flight request.