Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2006)

Unified Diff: pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart

Issue 2958753002: Conditionally add default argument to metadata (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart
diff --git a/pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart b/pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart
index e9c2c07431f461f1f1d6aef00ca8d767041d2a2c..6b8fa7b0da948f24df98c33cdac67e06c23e5c82 100644
--- a/pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart
+++ b/pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart
@@ -143,10 +143,11 @@ class ContainerBuilder extends CodeEmitterHelper {
: js.quoteName(tearOffName))
..add(js.number(requiredParameterCount))
..add(js.number(optionalParameterCount))
- ..add(memberTypeExpression == null ? js("null") : memberTypeExpression)
- ..addAll(task.metadataCollector.reifyDefaultArguments(member));
+ ..add(memberTypeExpression == null ? js("null") : memberTypeExpression);
if (canBeReflected || canBeApplied) {
+ expressions.addAll(task.metadataCollector.reifyDefaultArguments(member));
+
// TODO(redemption): Support entities.
MethodElement method = member;
method.functionSignature.forEachParameter((Element parameter) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698