Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Issue 2958623002: Re-introduce corrupted type inference tests. (Closed)

Created:
3 years, 6 months ago by Paul Berry
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Re-introduce corrupted type inference tests. These two tests were added some time ago, but they became corrupted (presumably due to a formatter bug that has since been fixed). Later, I moved the corrupted tests into the inference_new folder because they didn't infer correctly with analyzer. This CL re-introduces the original uncorrupted tests so that we don't lose test coverage. Note that these tests make use of a syntax that Fasta doesn't support yet, so they are marked as failing. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/0c1dab293364048bebe478343a46d7fb6974b118

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
A pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_dynamic_param_via_expr2.dart View 1 chunk +16 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/unsafe_block_closure_inference_function_call_explicit_type_param_via_expr2.dart View 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/strong.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 6 months ago (2017-06-23 21:10:10 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 6 months ago (2017-06-23 21:14:02 UTC) #3
Paul Berry
3 years, 6 months ago (2017-06-23 21:27:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0c1dab293364048bebe478343a46d7fb6974b118 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698