Update MediaStreamConstraintsAudioUtil unit tests.

content/renderer/media/media_stream_constraints_util_audio_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/media_stream_constraints_util_audio.h"
 
 #include <cmath>
 #include <string>
 #include <utility>
 
@@ skipping 324 matching lines @@
       blink::BooleanConstraint blink::WebMediaTrackConstraintSet::*>
       kMainBoolConstraints = {
           &blink::WebMediaTrackConstraintSet::hotword_enabled,
           &blink::WebMediaTrackConstraintSet::disable_local_echo,
           &blink::WebMediaTrackConstraintSet::render_to_associated_sink};
 
   ASSERT_EQ(kMainSettings.size(), kMainBoolConstraints.size());
   for (auto set_function : kBoolSetFunctions) {
     for (auto accessor : kFactoryAccessors) {
       // Ideal advanced is ignored by the SelectSettings algorithm.
-      if (set_function == &blink::BooleanConstraint::SetIdeal &&
-          accessor == &MockConstraintFactory::AddAdvanced) {
+      // Using array elements instead of pointer values due to the comparison
+      // failing on some build configurations.
+      if (set_function == kBoolSetFunctions[1] &&
+          accessor == kFactoryAccessors[1]) {
         continue;
       }
       for (size_t i = 0; i < kMainSettings.size(); ++i) {
         for (bool value : kBoolValues) {
           ResetFactory();
           (((constraint_factory_.*accessor)().*kMainBoolConstraints[i]).*
            set_function)(value);
           auto result = SelectSettings();
           EXPECT_TRUE(result.HasValue());
           EXPECT_EQ(value, (result.*kMainSettings[i])());
@@ skipping 30 matching lines @@
           &blink::WebMediaTrackConstraintSet::goog_highpass_filter,
           &blink::WebMediaTrackConstraintSet::
               goog_experimental_auto_gain_control,
       };
 
   ASSERT_EQ(kAudioProcessingProperties.size(),
             kAudioProcessingConstraints.size());
   for (auto set_function : kBoolSetFunctions) {
     for (auto accessor : kFactoryAccessors) {
       // Ideal advanced is ignored by the SelectSettings algorithm.
-      if (set_function == &blink::BooleanConstraint::SetIdeal &&
-          accessor == &MockConstraintFactory::AddAdvanced) {
+      // Using array elements instead of pointer values due to the comparison
+      // failing on some build configurations.
+      if (set_function == kBoolSetFunctions[1] &&
+          accessor == kFactoryAccessors[1]) {
         continue;
       }
       for (size_t i = 0; i < kAudioProcessingProperties.size(); ++i) {
         for (bool value : kBoolValues) {
           ResetFactory();
           (((constraint_factory_.*accessor)().*kAudioProcessingConstraints[i]).*
            set_function)(value);
           auto result = SelectSettings();
           EXPECT_TRUE(result.HasValue());
           EXPECT_EQ(value, result.audio_processing_properties().*
@@ skipping 69 matching lines @@
     }
   }
 }
 
 // Tests the echoCancellation constraint with a device without hardware echo
 // cancellation.
 TEST_P(MediaStreamConstraintsUtilAudioTest, EchoCancellationWithSw) {
   for (auto set_function : kBoolSetFunctions) {
     for (auto accessor : kFactoryAccessors) {
       // Ideal advanced is ignored by the SelectSettings algorithm.
-      if (set_function == &blink::BooleanConstraint::SetIdeal &&
-          accessor == &MockConstraintFactory::AddAdvanced) {
+      // Using array elements instead of pointer values due to the comparison
+      // failing on some build configurations.
+      if (set_function == kBoolSetFunctions[1] &&
+          accessor == kFactoryAccessors[1]) {
         continue;
       }
       for (bool value : kBoolValues) {
         ResetFactory();
         ((constraint_factory_.*accessor)().echo_cancellation.*
          set_function)(value);
         auto result = SelectSettings();
         EXPECT_TRUE(result.HasValue());
         const AudioProcessingProperties& properties =
             result.audio_processing_properties();
@@ skipping 40 matching lines @@
 // cancellation.
 TEST_P(MediaStreamConstraintsUtilAudioTest, EchoCancellationWithHw) {
   // With content capture, there is no hardware echo cancellation, so
   // nothing to test.
   if (!IsDeviceCapture())
     return;
 
   for (auto set_function : kBoolSetFunctions) {
     for (auto accessor : kFactoryAccessors) {
       // Ideal advanced is ignored by the SelectSettings algorithm.
-      if (set_function == &blink::BooleanConstraint::SetIdeal &&
-          accessor == &MockConstraintFactory::AddAdvanced) {
+      // Using array elements instead of pointer values due to the comparison
+      // failing on some build configurations.
+      if (set_function == kBoolSetFunctions[1] &&
+          accessor == kFactoryAccessors[1]) {
         continue;
       }
       for (bool value : kBoolValues) {
         ResetFactory();
         constraint_factory_.basic().device_id.SetExact(
             blink::WebString::FromASCII(hw_echo_canceller_device_->device_id));
         ((constraint_factory_.*accessor)().echo_cancellation.*
          set_function)(value);
         auto result = SelectSettings();
         EXPECT_TRUE(result.HasValue());
@@ skipping 25 matching lines @@
     }
   }
 }
 
 // Tests the googEchoCancellation constraint with a device without hardware echo
 // cancellation.
 TEST_P(MediaStreamConstraintsUtilAudioTest, GoogEchoCancellationWithSw) {
   for (auto set_function : kBoolSetFunctions) {
     for (auto accessor : kFactoryAccessors) {
       // Ideal advanced is ignored by the SelectSettings algorithm.
-      if (set_function == &blink::BooleanConstraint::SetIdeal &&
-          accessor == &MockConstraintFactory::AddAdvanced) {
+      // Using array elements instead of pointers due to the comparison failing
+      // on compilers.
+      if (set_function == kBoolSetFunctions[1] &&
+          accessor == kFactoryAccessors[1]) {
         continue;
       }
       for (bool value : kBoolValues) {
         ResetFactory();
         ((constraint_factory_.*accessor)().goog_echo_cancellation.*
          set_function)(value);
         auto result = SelectSettings();
         EXPECT_TRUE(result.HasValue());
         const AudioProcessingProperties& properties =
             result.audio_processing_properties();
@@ skipping 23 matching lines @@
 // cancellation.
 TEST_P(MediaStreamConstraintsUtilAudioTest, GoogEchoCancellationWithHw) {
   // With content capture, there is no hardware echo cancellation, so
   // nothing to test.
   if (!IsDeviceCapture())
     return;
 
   for (auto set_function : kBoolSetFunctions) {
     for (auto accessor : kFactoryAccessors) {
       // Ideal advanced is ignored by the SelectSettings algorithm.
-      if (set_function == &blink::BooleanConstraint::SetIdeal &&
-          accessor == &MockConstraintFactory::AddAdvanced) {
+      // Using array elements instead of pointer values due to the comparison
+      // failing on some build configurations.
+      if (set_function == kBoolSetFunctions[1] &&
+          accessor == kFactoryAccessors[1]) {
         continue;
       }
       for (bool value : kBoolValues) {
         ResetFactory();
         constraint_factory_.basic().device_id.SetExact(
             blink::WebString::FromASCII(hw_echo_canceller_device_->device_id));
         ((constraint_factory_.*accessor)().goog_echo_cancellation.*
          set_function)(value);
         auto result = SelectSettings();
         EXPECT_TRUE(result.HasValue());
@@ skipping 60 matching lines @@
           &blink::WebMediaTrackConstraintSet::goog_highpass_filter,
           &blink::WebMediaTrackConstraintSet::
               goog_experimental_auto_gain_control,
       };
 
   ASSERT_EQ(kAudioProcessingProperties.size(),
             kAudioProcessingConstraints.size());
   for (auto set_function : kBoolSetFunctions) {
     for (auto accessor : kFactoryAccessors) {
       // Ideal advanced is ignored by the SelectSettings algorithm.
-      if (set_function == &blink::BooleanConstraint::SetIdeal &&
-          accessor == &MockConstraintFactory::AddAdvanced) {
+      // Using array elements instead of pointer values due to the comparison
+      // failing on some build configurations.
+      if (set_function == kBoolSetFunctions[1] &&
+          accessor == kFactoryAccessors[1]) {
         continue;
       }
       for (size_t i = 0; i < kAudioProcessingProperties.size(); ++i) {
         ResetFactory();
         ((constraint_factory_.*accessor)().echo_cancellation.*
          set_function)(false);
         (((constraint_factory_.*accessor)().*kAudioProcessingConstraints[i]).*
          set_function)(true);
         auto result = SelectSettings();
         EXPECT_TRUE(result.HasValue());
@@ skipping 75 matching lines @@
 
 // Test that a valid geometry is interpreted correctly in all the ways it can
 // be set.
 TEST_P(MediaStreamConstraintsUtilAudioTest, ValidGeometry) {
   const blink::WebString kGeometry =
       blink::WebString::FromASCII("-0.02 0 0 0.02 0 1.01");
 
   for (auto set_function : kStringSetFunctions) {
     for (auto accessor : kFactoryAccessors) {
       // Ideal advanced is ignored by the SelectSettings algorithm.
-      // Using kStringSetFunctions[1] instead of
-      // static_cast<StringSetFunction>(&blink::StringConstraint::SetIdeal)
-      // because the equality comparison provides the wrong result in the
-      // Windows Debug build, making the test fail.
+      // Using array elements instead of pointer values due to the comparison
+      // failing on some build configurations.
       if (set_function == kStringSetFunctions[1] &&
-          accessor == &MockConstraintFactory::AddAdvanced) {
+          accessor == kFactoryAccessors[1]) {
         continue;
       }
       ResetFactory();
       ((constraint_factory_.*accessor)().goog_array_geometry.*
        set_function)(kGeometry);
       auto result = SelectSettings();
       EXPECT_TRUE(result.HasValue());
       CheckDeviceDefaults(result);
       CheckBoolDefaults(AudioSettingsBoolMembers(),
                         AudioPropertiesBoolMembers(), result);
       const std::vector<media::Point>& geometry =
           result.audio_processing_properties().goog_array_geometry;
       EXPECT_EQ(2u, geometry.size());
       EXPECT_EQ(media::Point(-0.02, 0, 0), geometry[0]);
       EXPECT_EQ(media::Point(0.02, 0, 1.01), geometry[1]);
     }
   }
 }
 
 // Test that an invalid geometry is interpreted as empty in all the ways it can
 // be set.
 TEST_P(MediaStreamConstraintsUtilAudioTest, InvalidGeometry) {
   const blink::WebString kGeometry =
       blink::WebString::FromASCII("1 1 1 invalid");
 
   for (auto set_function : kStringSetFunctions) {
     for (auto accessor : kFactoryAccessors) {
       // Ideal advanced is ignored by the SelectSettings algorithm.
-      if (set_function == static_cast<StringSetFunction>(
-                              &blink::StringConstraint::SetIdeal) &&
-          accessor == &MockConstraintFactory::AddAdvanced) {
+      // Using array elements instead of pointer values due to the comparison
+      // failing on some build configurations.
+      if (set_function == kStringSetFunctions[1] &&
+          accessor == kFactoryAccessors[1]) {
         continue;
       }
       ResetFactory();
       ((constraint_factory_.*accessor)().goog_array_geometry.*
        set_function)(kGeometry);
       auto result = SelectSettings();
       EXPECT_TRUE(result.HasValue());
       CheckDeviceDefaults(result);
       CheckBoolDefaults(AudioSettingsBoolMembers(),
                         AudioPropertiesBoolMembers(), result);
@@ skipping 85 matching lines @@
 }
 
 INSTANTIATE_TEST_CASE_P(,
                         MediaStreamConstraintsUtilAudioTest,
                         testing::Values("",
                                         kMediaStreamSourceTab,
                                         kMediaStreamSourceSystem,
                                         kMediaStreamSourceDesktop));
 
 }  // namespace content