Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 2958533003: Disable Credential management API dialog in VR mode (Closed)
Patch Set: cr feedback Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 5 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
6 #define CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 6 #define CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
173 // means that nothing was chosen. |one_local_credential| is true if there was 173 // means that nothing was chosen. |one_local_credential| is true if there was
174 // just one local credential to be chosen from. 174 // just one local credential to be chosen from.
175 void OnCredentialsChosen(const CredentialsCallback& callback, 175 void OnCredentialsChosen(const CredentialsCallback& callback,
176 bool one_local_credential, 176 bool one_local_credential,
177 const autofill::PasswordForm* form); 177 const autofill::PasswordForm* form);
178 178
179 // Returns true if this profile has metrics reporting and active sync 179 // Returns true if this profile has metrics reporting and active sync
180 // without custom sync passphrase. 180 // without custom sync passphrase.
181 static bool ShouldAnnotateNavigationEntries(Profile* profile); 181 static bool ShouldAnnotateNavigationEntries(Profile* profile);
182 182
183 bool IsInVr() const;
vabr (Chromium) 2017/06/30 10:06:07 nit: Please comment on the purpose of this, bearin
billorr 2017/06/30 17:54:18 Done.
184
183 Profile* const profile_; 185 Profile* const profile_;
184 186
185 password_manager::PasswordManager password_manager_; 187 password_manager::PasswordManager password_manager_;
186 188
187 // TODO(crbug.com/706392): Fix password reuse detection for Android. 189 // TODO(crbug.com/706392): Fix password reuse detection for Android.
188 #if !defined(OS_ANDROID) 190 #if !defined(OS_ANDROID)
189 password_manager::PasswordReuseDetectionManager 191 password_manager::PasswordReuseDetectionManager
190 password_reuse_detection_manager_; 192 password_reuse_detection_manager_;
191 #endif 193 #endif
192 194
(...skipping 27 matching lines...) Expand all
220 std::unique_ptr<autofill::PasswordForm> possible_auto_sign_in_; 222 std::unique_ptr<autofill::PasswordForm> possible_auto_sign_in_;
221 223
222 // If set, this stores a ukm::SourceId that is bound to the last committed 224 // If set, this stores a ukm::SourceId that is bound to the last committed
223 // navigation of the tab owning this ChromePasswordManagerClient. 225 // navigation of the tab owning this ChromePasswordManagerClient.
224 base::Optional<ukm::SourceId> ukm_source_id_; 226 base::Optional<ukm::SourceId> ukm_source_id_;
225 227
226 DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient); 228 DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient);
227 }; 229 };
228 230
229 #endif // CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_ 231 #endif // CHROME_BROWSER_PASSWORD_MANAGER_CHROME_PASSWORD_MANAGER_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698