third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp - Issue 2958483003: Make VisiblePosition::BeforeNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

Issue 2958483003: Make VisiblePosition::BeforeNode() to take const Node& instead of Node* (Closed)

Patch Set: 017-06-23T18:57:25 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/InsertLineBreakCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

index 3635296fc86f3c0389fc2a47d5afeae507785099..1daf220372b4852c13b246c14b9669cb1c861369 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

@@ -527,7 +527,7 @@ void InsertListCommand::UnlistifyParagraph(

start = CreateVisiblePosition(start_position);

end = CreateVisiblePosition(end_position);

- VisiblePosition insertion_point = VisiblePosition::BeforeNode(placeholder);

+ VisiblePosition insertion_point = VisiblePosition::BeforeNode(*placeholder);

MoveParagraphs(start, end, insertion_point, editing_state, kPreserveSelection,

kPreserveStyle, list_child_node);

}

@@ -680,7 +680,7 @@ void InsertListCommand::MoveParagraphOverPositionIntoEmptyListItem(

StartOfParagraph(valid_pos, kCanSkipOverEditingBoundary);

const VisiblePosition& end =

EndOfParagraph(valid_pos, kCanSkipOverEditingBoundary);

- MoveParagraph(start, end, VisiblePosition::BeforeNode(placeholder),

+ MoveParagraph(start, end, VisiblePosition::BeforeNode(*placeholder),

editing_state, kPreserveSelection);

}