Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: chromecast/media/cma/backend/alsa/post_processors/saturated_gain_unittest.cc

Issue 2958393002: Add a simple, safe gain PostProcessor. (Closed)
Patch Set: Unrelated cleanup Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/media/cma/backend/alsa/post_processors/saturated_gain_unittest.cc
diff --git a/chromecast/media/cma/backend/alsa/post_processors/saturated_gain_unittest.cc b/chromecast/media/cma/backend/alsa/post_processors/saturated_gain_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..bad7b96e160cb57e14d0a97326848221a1219f0b
--- /dev/null
+++ b/chromecast/media/cma/backend/alsa/post_processors/saturated_gain_unittest.cc
@@ -0,0 +1,54 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <string>
+#include <vector>
+
+#include "base/strings/stringprintf.h"
+#include "chromecast/media/cma/backend/alsa/post_processor_factory.h"
+#include "chromecast/media/cma/backend/alsa/post_processors/post_processor_unittest.h"
+
+namespace chromecast {
+namespace media {
+namespace post_processor_test {
+
+namespace {
+
+const char kConfigTemplate[] =
+ R"config({"gain_db": %f})config";
+
+const char kLibraryPath[] = "libcast_saturated_gain_1.0.so";
+
+std::string MakeConfigString(float gain_db) {
+ return base::StringPrintf(kConfigTemplate, gain_db);
+}
+
+} // namespace
+
+// Default tests from post_processor_test
+TEST_P(PostProcessorTest, SaturatedGainDelay) {
+ PostProcessorFactory factory;
+ std::string config = MakeConfigString(0.0);
+ auto pp = factory.CreatePostProcessor(kLibraryPath, config, kNumChannels);
+ TestDelay(pp.get(), sample_rate_);
+}
+
+TEST_P(PostProcessorTest, SaturatedGainRinging) {
+ PostProcessorFactory factory;
+ std::string config = MakeConfigString(0.0);
+ auto pp = factory.CreatePostProcessor(kLibraryPath, config, kNumChannels);
+ TestRingingTime(pp.get(), sample_rate_);
+}
+
+// Also tests clipping (by attempting to set gain way too high).
+TEST_P(PostProcessorTest, SaturatedGainPassthrough) {
+ PostProcessorFactory factory;
+ std::string config = MakeConfigString(100.0);
+ auto pp = factory.CreatePostProcessor(kLibraryPath, config, kNumChannels);
+ TestPassthrough(pp.get(), sample_rate_);
+}
+
+} // namespace post_processor_test
+} // namespace media
+} // namespace chromecast

Powered by Google App Engine
This is Rietveld 408576698