Add a simple, safe gain PostProcessor.

chromecast/media/cma/backend/alsa/post_processors/governor_unittest.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <cmath>
 #include <cstdint>
 #include <limits>
 #include <string>
 #include <vector>
 
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/stringprintf.h"
 #include "chromecast/media/cma/backend/alsa/post_processors/governor.h"
 #include "chromecast/media/cma/backend/alsa/post_processors/post_processor_unittest.h"
-#include "media/base/audio_bus.h"
-#include "media/base/audio_sample_types.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace chromecast {
 namespace media {
 namespace post_processor_test {
 
 namespace {
 
 const char* kConfigTemplate =
     R"config({"onset_volume": %f, "clamp_multiplier": %f})config";
@@ skipping 76 matching lines @@
     ScaleData(expected_.data(), kNumFrames * kNumChannels, clamp_);
   }
   CompareBuffers();
 }
 
 INSTANTIATE_TEST_CASE_P(GovernorClampVolumeTest,
                         GovernorTest,
                         ::testing::Values(0.0f, 0.1f, 0.5f, 0.9f, 1.0f, 1.1f));
 
 // Default tests from post_processor_test
-TEST_P(PostProcessorTest, TestDelay) {
+TEST_P(PostProcessorTest, GovernorDelay) {
   std::string config = MakeConfigString(1.0, 1.0);
   auto pp =
-      base::WrapUnique(AudioPostProcessorShlib_Create(config, kNumChannels));
+      base::WrapUnique<AudioPostProcessor>(new Governor(config, kNumChannels));

[kmackay, 2017/07/06 22:16:28]

Why not make this work the same way as saturated_gain_unittest.cc (ie, use the
factory to create the post processor)?

[bshaya, 2017/07/06 22:38:10]

Done.

   TestDelay(pp.get(), sample_rate_);
 }
 
-TEST_P(PostProcessorTest, TestRinging) {
+TEST_P(PostProcessorTest, GovernorRinging) {
   std::string config = MakeConfigString(1.0, 1.0);
   auto pp =
-      base::WrapUnique(AudioPostProcessorShlib_Create(config, kNumChannels));
+      base::WrapUnique<AudioPostProcessor>(new Governor(config, kNumChannels));
   TestRingingTime(pp.get(), sample_rate_);
 }
 
-TEST_P(PostProcessorTest, TestPassthrough) {
+TEST_P(PostProcessorTest, GovernorPassthrough) {
   std::string config = MakeConfigString(1.0, 1.0);
   auto pp =
-      base::WrapUnique(AudioPostProcessorShlib_Create(config, kNumChannels));
+      base::WrapUnique<AudioPostProcessor>(new Governor(config, kNumChannels));
   TestPassthrough(pp.get(), sample_rate_);
 }
 
 }  // namespace post_processor_test
 }  // namespace media
 }  // namespace chromecast