Issue 2958363002: Adjust return types of spec-mode function expressions to match VM.

Issue 2958363002: Adjust return types of spec-mode function expressions to match VM. (Closed)

Created:
3 years, 5 months ago by Paul Berry

Modified:
3 years, 5 months ago

Reviewers:
ahe, scheglov

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Adjust return types of spec-mode function expressions to match VM. R=scheglov@google.com The spec is unclear about what is supposed to happen here (see https://github.com/dart-lang/sdk/issues/30044). Matching the VM behavior allows us to pass the existing tests. Committed: https://github.com/dart-lang/sdk/commit/0958e40357845aae651bd61851b541968711ba9a

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -13 lines)			Patch
M	pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	pkg/front_end/testcases/inference/coerce_bottom_and_null_types.dart.direct.expect	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	pkg/front_end/testcases/inference/lambda_return_type.dart.direct.expect	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/front_end/testcases/inference/super_property_get_invoke_function_typed.dart.direct.expect	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/co19/co19-kernel.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/language/language_kernel.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

3 years, 5 months ago (2017-06-28 21:36:05 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0958e40357845aae651bd61851b541968711ba9a (presubmit successful).