[Payments] Implement web payment app manifest

third_party/WebKit/Source/modules/payments/PaymentInstruments.cpp

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/payments/PaymentInstruments.h"
 
 #include <utility>
 
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "bindings/core/v8/V8BindingForCore.h"
 #include "core/dom/DOMException.h"
+#include "core/inspector/ConsoleMessage.h"
 #include "modules/payments/PaymentInstrument.h"
 #include "modules/payments/PaymentManager.h"
 #include "platform/wtf/Vector.h"
 
 namespace blink {
 namespace {
 
 static const char kPaymentManagerUnavailable[] = "Payment manager unavailable";
 
 bool rejectError(ScriptPromiseResolver* resolver,
@@ skipping 15 matching lines @@
       return true;
     case payments::mojom::blink::PaymentHandlerStatus::STORAGE_OPERATION_FAILED:
       resolver->Reject(DOMException::Create(kInvalidStateError,
                                             "Storage operation is failed"));
       return true;
     case payments::mojom::blink::PaymentHandlerStatus::
         FETCH_INSTRUMENT_ICON_FAILED:
       resolver->Reject(DOMException::Create(
           kNotFoundError, "Fetch or decode instrument icon failed"));
       return true;
+    case payments::mojom::blink::PaymentHandlerStatus::
+        FETCH_PAYMENT_APP_INFO_FAILED:
+      // FETCH_PAYMENT_APP_INFO_FAILED indicates everything works well except
+      // fetching payment app's manifest. The alternative value for the payment
+      // app will be used in this case, so only show warnning message instead of
+      // reject the promise.
+      ExecutionContext* context =
+          ExecutionContext::From(resolver->GetScriptState());
+      context->AddConsoleMessage(
+          ConsoleMessage::Create(kJSMessageSource, kWarningMessageLevel,
+                                 "Fetch payment app's info (manifest or the "
+                                 "field in the manifest) failed."));

[please use gerrit instead, 2017/06/30 15:43:30]

A couple of comments:

1) Payment app is not the terminology used by W3C. They call it "payment
handler". Let's use that language as well.

2) Let the web developer know what is the impact of this error.

Here's the text that I propose:

"Unable to fetch payment handler's name and icon from its web app manifest. User
may not recognize this payment handler in UI, because it will be labeled only by
its origin."

[gogerald1, 2017/06/30 16:25:09]

Done.

+      return false;
   }
   NOTREACHED();
   return false;
 }
 
 }  // namespace
 
 PaymentInstruments::PaymentInstruments(
     const payments::mojom::blink::PaymentManagerPtr& manager)
     : manager_(manager) {}
@@ skipping 225 matching lines @@
 void PaymentInstruments::onClearPaymentInstruments(
     ScriptPromiseResolver* resolver,
     payments::mojom::blink::PaymentHandlerStatus status) {
   DCHECK(resolver);
   if (rejectError(resolver, status))
     return;
   resolver->Resolve();
 }
 
 }  // namespace blink