Revert 271461 "Decouple RVH creation from CrossProcessFrameConne..."

Revert 271461 "Decouple RVH creation from CrossProcessFrameConne..."

This broke the same android tests that failed 2 out of 3 times on your presubmit
try jobs.

> Decouple RVH creation from CrossProcessFrameConnector.
> 
> The RenderViewHost creation today takes a CrossProcessFrameConnector pointer, which it uses to decide whether to create a top-level or child frame view. Replace this with a boolean and associate the CrossProcessFrameConnector with the view at a later point in time.
> 
> BUG=357747
> 
> Review URL: https://codereview.chromium.org/270883003

TBR=nasko@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271516

[ericu, 2014-05-19 23:47:35]

Committed patchset #1 manually as r271516.

[boliu, 2014-05-20 00:18:03]

Stack from bots below. It's not immediately obvious what's wrong, but I'm
looking:

Stack Trace:
  RELADDR   FUNCTION                                                            
                                                                                
                                                                                
                                                                                
                                      FILE:LINE
  002e26f8  JavaObjectWeakGlobalRef::get(_JNIEnv*) const+8                      
                                                                                
                                                                                
                                                                                
                                      libgcc2.c:0
  00854973  content::ContentViewCoreImpl::UpdateFrameInfo(gfx::Vector2dF const&,
float, gfx::Vector2dF const&, gfx::SizeF const&, gfx::SizeF const&,
gfx::Vector2dF const&, gfx::Vector2dF const&, float)+62                         
                                                                                
                                                   libgcc2.c:0
  0098675d 
content::RenderWidgetHostViewAndroid::OnFrameMetadataUpdated(cc::CompositorFrameMetadata
const&)+120                                                                     
                                                                                
                                                                                
                  libgcc2.c:0
  0098934b 
content::RenderWidgetHostViewAndroid::SynchronousFrameMetadata(cc::CompositorFrameMetadata
const&)+10                                                                      
                                                                                
                                                                                
                libgcc2.c:0
  0085b7cf 
content::SynchronousCompositorOutputSurface::UpdateFrameMetaData(cc::CompositorFrameMetadata
const&)+382                                                                     
                                                                                
                                                                                
              libgcc2.c:0
  0085b8b1 
content::SynchronousCompositorOutputSurface::SwapBuffers(cc::CompositorFrame*)+172
                                                                                
                                                                                
                                                                                
                        libgcc2.c:0
  0027f619  cc::SoftwareRenderer::SwapBuffers(cc::CompositorFrameMetadata
const&)+248                                                                     
                                                                                
                                                                                
                                             libgcc2.c:0
  002bf72d  cc::LayerTreeHostImpl::SwapBuffers(cc::LayerTreeHostImpl::FrameData
const&)+236                                                                     
                                                                                
                                                                                
                                       libgcc2.c:0
  002d4bbd  cc::ThreadProxy::DrawSwapInternal(bool)+588                         
                                                                                
                                                                                
                                                                                
                                      libgcc2.c:0
  002d4f53  cc::ThreadProxy::ScheduledActionDrawAndSwapIfPossible()+170         
                                                                                
                                                                                
                                                                                
                                      libgcc2.c:0
  002af715  cc::Scheduler::DrawAndSwapIfPossible()+10                           
                                                                                
                                                                                
                                                                                
                                      libgcc2.c:0
  002b0e13  cc::Scheduler::ProcessScheduledActions()+266                        
                                                                                
                                                                                
                                                                                
                                      libgcc2.c:0
  002b133d  cc::Scheduler::OnBeginImplFrameDeadline()+112                       
                                                                                
                                                                                
                                                                                
                                      libgcc2.c:0
  002b137d  cc::Scheduler::ScheduleBeginImplFrameDeadline(base::TimeTicks)+16   
                                                                                
                                                                                
                                                                                
                                      libgcc2.c:0
  002b1605  cc::Scheduler::BeginImplFrame(cc::BeginFrameArgs const&)+524        
                                                                                
                                                                                
                                                                                
                                      libgcc2.c:0
  002b1abb  cc::Scheduler::BeginFrame(cc::BeginFrameArgs const&)+278            
                                                                                
                                                                                
                                                                                
                                      libgcc2.c:0
  002be8af  cc::LayerTreeHostImpl::BeginFrame(cc::BeginFrameArgs const&)+8      
                                                                                
                                                                                
                                                                                
                                      libgcc2.c:0
  0085b2b9 
content::SynchronousCompositorOutputSurface::InvokeComposite(gfx::Transform
const&, gfx::Rect, gfx::Rect, bool)+240                                         
                                                                                
                                                                                
                               libgcc2.c:0
  0085b567 
content::SynchronousCompositorOutputSurface::DemandDrawSw(SkCanvas*)+266        
                                                                                
                                                                                
                                                                                
                          libgcc2.c:0
  0085a21b  content::SynchronousCompositorImpl::DemandDrawSw(SkCanvas*)+98      
                                                                                
                                                                                
                                                                                
                                      libgcc2.c:0
  00209d35  android_webview::BrowserViewRenderer::CompositeSW(SkCanvas*)+72     
                                                                                
                                                                                
                                                                                
                                      libgcc2.c:0
  0020adb7  android_webview::BrowserViewRenderer::ForceFakeCompositeSW()+130    
                                                                                
                                                                                
                                                                                
                                      libgcc2.c:0
  0020b00b  android_webview::BrowserViewRenderer::FallbackTickFired()+170       
                                                                                
                                                                                
                                                                                
                                      libgcc2.c:0