src/wasm/wasm-module.h - Issue 2958283003: [wasm] Naming convention: get_origin() -> origin()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/wasm/wasm-module.h

Issue 2958283003: [wasm] Naming convention: get_origin() -> origin() (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/wasm/wasm-module.h

diff --git a/src/wasm/wasm-module.h b/src/wasm/wasm-module.h

index bc67d66436f4fb81bb05a67bbc38a355d311943e..a39bd0b88f779dc877cd97398780d06260b0490d 100644

--- a/src/wasm/wasm-module.h

+++ b/src/wasm/wasm-module.h

@@ -187,7 +187,7 @@ struct V8_EXPORT_PRIVATE WasmModule {

WasmModule() : WasmModule(nullptr) {}

WasmModule(std::unique_ptr<Zone> owned);

- ModuleOrigin get_origin() const { return origin_; }

+ ModuleOrigin origin() const { return origin_; }

void set_origin(ModuleOrigin new_value) { origin_ = new_value; }

bool is_wasm() const { return origin_ == kWasmOrigin; }

bool is_asm_js() const { return origin_ == kAsmJsOrigin; }

« no previous file with comments | « src/wasm/module-compiler.cc ('k') | test/cctest/wasm/wasm-run-utils.h » ('j') | no next file with comments »