Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Side by Side Diff: src/wasm/module-compiler.cc

Issue 2958283003: [wasm] Naming convention: get_origin() -> origin() (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/wasm-compiler.cc ('k') | src/wasm/wasm-module.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 the V8 project authors. All rights reserved. 1 // Copyright 2017 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <src/wasm/module-compiler.h> 5 #include <src/wasm/module-compiler.h>
6 6
7 #include <atomic> 7 #include <atomic>
8 8
9 #include "src/asmjs/asm-js.h" 9 #include "src/asmjs/asm-js.h"
10 #include "src/assembler-inl.h" 10 #include "src/assembler-inl.h"
(...skipping 1285 matching lines...) Expand 10 before | Expand all | Expand 10 after
1296 // Function imports must be callable. 1296 // Function imports must be callable.
1297 if (!value->IsCallable()) { 1297 if (!value->IsCallable()) {
1298 ReportLinkError("function import requires a callable", index, 1298 ReportLinkError("function import requires a callable", index,
1299 module_name, import_name); 1299 module_name, import_name);
1300 return -1; 1300 return -1;
1301 } 1301 }
1302 1302
1303 Handle<Code> import_wrapper = UnwrapOrCompileImportWrapper( 1303 Handle<Code> import_wrapper = UnwrapOrCompileImportWrapper(
1304 isolate_, index, module_->functions[import.index].sig, 1304 isolate_, index, module_->functions[import.index].sig,
1305 Handle<JSReceiver>::cast(value), module_name, import_name, 1305 Handle<JSReceiver>::cast(value), module_name, import_name,
1306 module_->get_origin(), &imported_wasm_instances); 1306 module_->origin(), &imported_wasm_instances);
1307 if (import_wrapper.is_null()) { 1307 if (import_wrapper.is_null()) {
1308 ReportLinkError("imported function does not match the expected type", 1308 ReportLinkError("imported function does not match the expected type",
1309 index, module_name, import_name); 1309 index, module_name, import_name);
1310 return -1; 1310 return -1;
1311 } 1311 }
1312 code_table->set(num_imported_functions, *import_wrapper); 1312 code_table->set(num_imported_functions, *import_wrapper);
1313 RecordStats(*import_wrapper, counters()); 1313 RecordStats(*import_wrapper, counters());
1314 num_imported_functions++; 1314 num_imported_functions++;
1315 break; 1315 break;
1316 } 1316 }
(...skipping 1035 matching lines...) Expand 10 before | Expand all | Expand 10 after
2352 HandleScope scope(job_->isolate_); 2352 HandleScope scope(job_->isolate_);
2353 Handle<WasmModuleObject> result = 2353 Handle<WasmModuleObject> result =
2354 WasmModuleObject::New(job_->isolate_, job_->compiled_module_); 2354 WasmModuleObject::New(job_->isolate_, job_->compiled_module_);
2355 // {job_} is deleted in AsyncCompileSucceeded, therefore the {return}. 2355 // {job_} is deleted in AsyncCompileSucceeded, therefore the {return}.
2356 return job_->AsyncCompileSucceeded(result); 2356 return job_->AsyncCompileSucceeded(result);
2357 } 2357 }
2358 }; 2358 };
2359 } // namespace wasm 2359 } // namespace wasm
2360 } // namespace internal 2360 } // namespace internal
2361 } // namespace v8 2361 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/wasm-compiler.cc ('k') | src/wasm/wasm-module.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698