[DevTools] Show ARIA pane based on whether AXNode is DOM node

third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilitySidebarView.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /**
  * @unrestricted
  */
 Accessibility.AccessibilitySidebarView = class extends UI.ThrottledWidget {
   constructor() {
     super();
     this._node = null;
@@ skipping 34 matching lines @@
 
   /**
    * @param {?Accessibility.AccessibilityNode} axNode
    */
   accessibilityNodeCallback(axNode) {
     if (!axNode)
       return;
 
     this._axNode = axNode;
 
-    if (axNode.ignored())
+    if (axNode.isDOMNode())

[lushnikov, 2017/06/28 18:21:00]

What is "ignored" axNode? Should the condition be

if (axNode.isDOMNode() && !axNode.ignored())
  ...

[aboxhall, 2017/06/28 21:06:32]

I deliberately removed that. Ignored means there is no AXNode, but ARIA can
affect that so we should show the ARIA pane anyway.

+      this._sidebarPaneStack.showView(this._ariaSubPane, this._axNodeSubPane);
+    else
       this._sidebarPaneStack.removeView(this._ariaSubPane);
-    else
-      this._sidebarPaneStack.showView(this._ariaSubPane, this._axNodeSubPane);
 
     if (this._axNodeSubPane)
       this._axNodeSubPane.setAXNode(axNode);
     if (this._breadcrumbsSubPane)
       this._breadcrumbsSubPane.setAXNode(axNode);
   }
 
   /**
    * @override
    * @protected
@@ skipping 126 matching lines @@
   createTreeOutline() {
     var treeOutline = new UI.TreeOutlineInShadow();
     treeOutline.registerRequiredCSS('accessibility/accessibilityNode.css');
     treeOutline.registerRequiredCSS('object_ui/objectValue.css');
 
     treeOutline.element.classList.add('hidden');
     this.element.appendChild(treeOutline.element);
     return treeOutline;
   }
 };