Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: services/resource_coordinator/coordination_unit/process_coordination_unit_impl.cc

Issue 2958133003: Enable GRC
Patch Set: Rebase Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/resource_coordinator/coordination_unit/process_coordination_unit_impl.cc
diff --git a/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.cc b/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.cc
index c92953208b8b6f95548165a0ee84c739542d9f6b..df68dbfd19b59683f33295747f3db0038560af7d 100644
--- a/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.cc
+++ b/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.cc
@@ -4,52 +4,14 @@
#include "services/resource_coordinator/coordination_unit/process_coordination_unit_impl.h"
-#include "base/process/process.h"
-#include "base/process/process_handle.h"
-#include "base/time/time.h"
#include "base/values.h"
-#if defined(OS_MACOSX)
-#include "services/service_manager/public/cpp/standalone_service/mach_broker.h"
-#endif
-
-#if defined(OS_WIN)
-#include <windows.h>
-#endif
-
namespace resource_coordinator {
-namespace {
-
-const int kCPUProfilingIntervalInSeconds = 5;
-
-} // namespace
-
ProcessCoordinationUnitImpl::ProcessCoordinationUnitImpl(
const CoordinationUnitID& id,
std::unique_ptr<service_manager::ServiceContextRef> service_ref)
- : CoordinationUnitImpl(id, std::move(service_ref)) {
- // ProcessCoordinationUnit ids should correspond to its pid
- base::ProcessId pid = id.id;
-#if defined(OS_WIN)
- base::Process process =
- base::Process::OpenWithAccess(pid, PROCESS_QUERY_INFORMATION);
-#else
- base::Process process = base::Process::Open(pid);
-#endif
- base::ProcessHandle process_handle = process.Handle();
-
-#if defined(OS_MACOSX)
- process_metrics_ = base::ProcessMetrics::CreateProcessMetrics(
- process_handle,
- service_manager::MachBroker::GetInstance()->port_provider());
-#else
- process_metrics_ = base::ProcessMetrics::CreateProcessMetrics(process_handle);
-#endif
-
- repeating_timer_.Start(FROM_HERE, base::TimeDelta(), this,
- &ProcessCoordinationUnitImpl::MeasureProcessCPUUsage);
-}
+ : CoordinationUnitImpl(id, std::move(service_ref)) {}
ProcessCoordinationUnitImpl::~ProcessCoordinationUnitImpl() = default;
@@ -96,15 +58,4 @@ void ProcessCoordinationUnitImpl::PropagateProperty(
}
}
-void ProcessCoordinationUnitImpl::MeasureProcessCPUUsage() {
- double cpu_usage = process_metrics_->GetPlatformIndependentCPUUsage();
-
- SetProperty(mojom::PropertyType::kCPUUsage,
- base::MakeUnique<base::Value>(cpu_usage));
-
- repeating_timer_.Start(
- FROM_HERE, base::TimeDelta::FromSeconds(kCPUProfilingIntervalInSeconds),
- this, &ProcessCoordinationUnitImpl::MeasureProcessCPUUsage);
-}
-
} // namespace resource_coordinator

Powered by Google App Engine
This is Rietveld 408576698