Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(904)

Unified Diff: net/quic/chromium/quic_stream_factory.h

Issue 2958133002: Change QuicStreamRequest::Request() to take a preferred QuicVersion so that (Closed)
Patch Set: Add QuicStreamFactoryTest Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/chromium/quic_stream_factory.h
diff --git a/net/quic/chromium/quic_stream_factory.h b/net/quic/chromium/quic_stream_factory.h
index 3942735a80d4cefad0da85a92d3d4feeb4e9e5ff..e05af7b46fdbfc14eee6ca1c820f3a5f4db4df82 100644
--- a/net/quic/chromium/quic_stream_factory.h
+++ b/net/quic/chromium/quic_stream_factory.h
@@ -115,6 +115,7 @@ class NET_EXPORT_PRIVATE QuicStreamRequest {
// |destination| will be resolved and resulting IPEndPoint used to open a
// QuicConnection. This can be different than HostPortPair::FromURL(url).
int Request(const HostPortPair& destination,
+ const QuicVersionVector& advertised_versions,
Ryan Hamilton 2017/06/28 18:53:14 The CL description talks about adding a single ver
Zhongyi Shi 2017/07/05 23:08:59 Thanks for pointing this out. I have updated the C
PrivacyMode privacy_mode,
int cert_verify_flags,
const GURL& url,
@@ -233,6 +234,7 @@ class NET_EXPORT_PRIVATE QuicStreamFactory
// OnRequestComplete asynchronously.
int Create(const QuicServerId& server_id,
const HostPortPair& destination,
+ const QuicVersionVector& advertised_versions,
int cert_verify_flags,
const GURL& url,
QuicStringPiece method,
@@ -404,6 +406,7 @@ class NET_EXPORT_PRIVATE QuicStreamFactory
bool HasActiveJob(const QuicServerId& server_id) const;
bool HasActiveCertVerifierJob(const QuicServerId& server_id) const;
int CreateSession(const QuicSessionKey& key,
+ const QuicVersion& quic_version,
int cert_verify_flags,
bool require_confirmation,
const AddressList& address_list,
@@ -417,6 +420,14 @@ class NET_EXPORT_PRIVATE QuicStreamFactory
void ConfigureInitialRttEstimate(const QuicServerId& server_id,
QuicConfig* config);
+ // Returns the first mutually supported QUIC version based on
+ // |supported_versions|. If there is no mutually supported QUIC version,
+ // return the first entry in |supported_versions_|.
+ // |supported_versions_| should be listed in the order of most preferred QUIC
+ // verions.
+ QuicVersion SelectQuicVersion(
+ const QuicVersionVector& advertised_versions) const;
+
// Returns |srtt| in micro seconds from ServerNetworkStats. Returns 0 if there
// is no |http_server_properties_| or if |http_server_properties_| doesn't
// have ServerNetworkStats for the given |server_id|.

Powered by Google App Engine
This is Rietveld 408576698