net/http/http_stream_factory_impl_job.h - Issue 2958133002: Change QuicStreamRequest::Request() to take a preferred QuicVersion so that

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_stream_factory_impl_job.h

Issue 2958133002: Change QuicStreamRequest::Request() to take a preferred QuicVersion so that (Closed)

Patch Set: Add QuicStreamFactoryTest Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_stream_factory_impl_job.h

diff --git a/net/http/http_stream_factory_impl_job.h b/net/http/http_stream_factory_impl_job.h

index dbfa4d13a46d7da9965b91fde1e4ff0e40d353c7..1f0df156877b554a3c16b4268cfd7e2dbaee136c 100644

--- a/net/http/http_stream_factory_impl_job.h

+++ b/net/http/http_stream_factory_impl_job.h

@@ -148,6 +148,8 @@ class HttpStreamFactoryImpl::Job {

virtual const NetLogWithSource* GetNetLog() const = 0;

+ virtual const QuicVersionVector& GetAdvertisedQuicVersions() const = 0;

Ryan Hamilton 2017/06/28 18:53:14 nit: Comment.

Zhongyi Shi 2017/07/05 23:08:59 This method has been removed.

virtual WebSocketHandshakeStreamBase::CreateHelper*

websocket_handshake_stream_create_helper() = 0;