Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2958113002: Test of type inference when super calls are unresolved. (Closed)

Created:
3 years, 5 months ago by Paul Berry
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Test of type inference when super calls are unresolved. See https://github.com/dart-lang/sdk/issues/30000 for an illustration of why this is necessary. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/474d5e5d7fc9d31cb20520b95b6873f1549de5c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
A pkg/front_end/testcases/inference/unresolved_super.dart View 1 chunk +20 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/unresolved_super.dart.direct.expect View 1 chunk +19 lines, -0 lines 0 comments Download
A pkg/front_end/testcases/inference/unresolved_super.dart.outline.expect View 1 chunk +14 lines, -0 lines 0 comments Download
M pkg/front_end/testcases/kompile.status View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/testcases/strong.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 5 months ago (2017-06-27 20:49:08 UTC) #2
scheglov
LGTM
3 years, 5 months ago (2017-06-27 20:55:40 UTC) #3
Paul Berry
3 years, 5 months ago (2017-06-27 21:10:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
474d5e5d7fc9d31cb20520b95b6873f1549de5c5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698