Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2958013002: Steps towards handling `new Element.div()` (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Steps towards handling `new Element.div()` - need to have a closure class for this. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/a6127e7361141425111947185e3420e1b068a887

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -11 lines) Patch
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 2 chunks +8 lines, -9 lines 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart View 3 chunks +7 lines, -1 line 2 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 5 months ago (2017-06-27 11:34:11 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2958013002/diff/1/tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart File tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart (right): https://codereview.chromium.org/2958013002/diff/1/tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart#newcode54 tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart:54: var toplevel; This seems a bit unrelated to ...
3 years, 5 months ago (2017-06-27 20:20:43 UTC) #3
Johnni Winther
https://codereview.chromium.org/2958013002/diff/1/tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart File tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart (right): https://codereview.chromium.org/2958013002/diff/1/tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart#newcode54 tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart:54: var toplevel; On 2017/06/27 20:20:43, Siggi Cherem (dart-lang) wrote: ...
3 years, 5 months ago (2017-06-28 08:09:05 UTC) #4
Johnni Winther
3 years, 5 months ago (2017-06-28 08:30:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a6127e7361141425111947185e3420e1b068a887 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698