Issue 2958012: [Mac] Bring back the omnibox globe for an encore.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2958012: [Mac] Bring back the omnibox globe for an encore. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by Scott Hess

Modified:
3 years, 11 months ago

Reviewers:
rohitrao (OOO until 6-22)

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org, Paweł Hajdan Jr.

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

[Mac] Bring back the omnibox globe for an encore. BUG=49077 TEST=Globe is back at LHS of omnibox. Draggable, droppable, clickable. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52385

Patch Set 1 #

Patch Set 2 : gclient sync #

Total comments: 6

Patch Set 3 : Rohit's suggestions. #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+74 lines, -2 lines)			Patch
M	chrome/browser/cocoa/location_bar/autocomplete_text_field_cell_unittest.mm	View		3 chunks	+13 lines, -1 line	0 comments	Download
M	chrome/browser/cocoa/location_bar/location_icon_decoration.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
A	chrome/browser/cocoa/location_bar/location_icon_decoration_unittest.mm	View	2	1 chunk	+59 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Trybot results: mac

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rohitrao (OOO until 6-22)

LGTM Woohoo unittests! http://codereview.chromium.org/2958012/diff/2001/3002 File chrome/browser/cocoa/location_bar/location_icon_decoration.mm (right): http://codereview.chromium.org/2958012/diff/2001/3002#newcode33 chrome/browser/cocoa/location_bar/location_icon_decoration.mm:33: if (image_width <= width) At least ...

4 years, 10 months ago (2010-07-14 18:38:49 UTC) #2

Scott Hess

4 years, 10 months ago (2010-07-14 18:48:13 UTC) #3

Now I just want an open waterfall...

http://codereview.chromium.org/2958012/diff/2001/3002
File chrome/browser/cocoa/location_bar/location_icon_decoration.mm (right):

http://codereview.chromium.org/2958012/diff/2001/3002#newcode33
chrome/browser/cocoa/location_bar/location_icon_decoration.mm:33: if
(image_width <= width)
On 2010/07/14 18:38:49, rohitrao wrote:
> At least it wasn't an off-by-one error.

I can only assume it was an accidental late edit, or I was concentrating on the
bubble decorations.

http://codereview.chromium.org/2958012/diff/2001/3003
File chrome/browser/cocoa/location_bar/location_icon_decoration_unittest.mm
(right):

http://codereview.chromium.org/2958012/diff/2001/3003#newcode37
chrome/browser/cocoa/location_bar/location_icon_decoration_unittest.mm:37: const
CGFloat kWide = 100.0, kNarrow = 10.0;
On 2010/07/14 18:38:49, rohitrao wrote:
> I prefer one variable per line.  Does the style guide say anything about this?

Done.

http://codereview.chromium.org/2958012/diff/2001/3003#newcode39
chrome/browser/cocoa/location_bar/location_icon_decoration_unittest.mm:39:
LocationBarDecoration::kOmittedWidth);
On 2010/07/14 18:38:49, rohitrao wrote:
> Can you add a comment like:
> // Decorations with no image should return kOmittedWidth.

Done.

Expand Messages | Collapse Messages