components/security_interstitials/core/browser/resources/list_of_interstitials.html - Issue 2957953002: Add pinned cert interstitial to chrome://interstitials

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/security_interstitials/core/browser/resources/list_of_interstitials.html

Issue 2957953002: Add pinned cert interstitial to chrome://interstitials (Closed)

Patch Set: Make pinned certificate error variable name more specific Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc ('K') | « chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/security_interstitials/core/browser/resources/list_of_interstitials.html

diff --git a/components/security_interstitials/core/browser/resources/list_of_interstitials.html b/components/security_interstitials/core/browser/resources/list_of_interstitials.html

index a759c82be283aad2c6795f7aa2ed4e372148bd4f..624b7c835ac50341b4ba5c28429af7368723fc09 100644

--- a/components/security_interstitials/core/browser/resources/list_of_interstitials.html

+++ b/components/security_interstitials/core/browser/resources/list_of_interstitials.html

@@ -40,6 +40,9 @@

<li>

<a href="clock?clock_manipulation=-2">Clock is behind</a>

</li>

+ <li>

+ <a href="ssl?overridable=0&strict_enforcement=0&type=hpkp_failure">Pinned certificate error</a>

meacer 2017/06/27 21:10:17 nit: Do we actually need overridable=0 and strict_

sperigo 2017/06/27 21:31:27 Doesn't look like it! I removed them.

+ </li>

</ul>

<h3>SafeBrowsing</h3>