Add pinned cert interstitial to chrome://interstitials

chrome/browser/ui/webui/interstitials/interstitial_ui_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/devtools/devtools_window.h"
 #include "chrome/browser/devtools/devtools_window_testing.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/public/browser/web_contents.h"
 
 class InterstitialUITest : public InProcessBrowserTest {
  public:
    InterstitialUITest() {}
    ~InterstitialUITest() override {}
 
  protected:
   void TestInterstitial(GURL url, const std::string& page_title) {
     ui_test_utils::NavigateToURL(browser(), url);
     EXPECT_EQ(
       base::ASCIIToUTF16(page_title),
       browser()->tab_strip_model()->GetActiveWebContents()->GetTitle());

[meacer, 2017/06/27 21:10:17]

nit: Not necessary for this CL, but we might also consider checking the text
inside the interstitial since most interstitials have the same "Privacy error"
title. There is a method called IsInterstitialDisplayingText() that we can use
for this.

[sperigo, 2017/06/27 21:31:27]

Good idea. I noticed these tests were pretty bare. Should I file that as a bug
for future reference?

[meacer, 2017/06/27 21:32:50]

Sure, feel free to file as a new bug.

 
     // Should also be able to open and close devtools.
     DevToolsWindow* window =
         DevToolsWindowTesting::OpenDevToolsWindowSync(browser(), true);
     EXPECT_TRUE(window);
     DevToolsWindowTesting::CloseDevToolsWindowSync(window);
   }
 };
 
 IN_PROC_BROWSER_TEST_F(InterstitialUITest, HomePage) {
   TestInterstitial(
       GURL("chrome://interstitials"),
       "Interstitials");
 }
 
 IN_PROC_BROWSER_TEST_F(InterstitialUITest, InvalidURLShouldOpenHomePage) {
   // Invalid path should open the main page:
   TestInterstitial(
       GURL("chrome://interstitials/--invalid--"),
       "Interstitials");
 }
 
 IN_PROC_BROWSER_TEST_F(InterstitialUITest, SSLInterstitial) {
   TestInterstitial(
       GURL("chrome://interstitials/ssl"),
       "Privacy error");
 }
 
+IN_PROC_BROWSER_TEST_F(InterstitialUITest, PinnedCertInterstitial) {
+  TestInterstitial(GURL("chrome://interstitials/ssl?type=hpkp_failure"),
+                   "Privacy error");
+}
+
 IN_PROC_BROWSER_TEST_F(InterstitialUITest, MalwareInterstitial) {
   TestInterstitial(
       GURL("chrome://interstitials/safebrowsing?type=malware"),
       "Security error");
 }
 
 IN_PROC_BROWSER_TEST_F(InterstitialUITest, PhishingInterstitial) {
   TestInterstitial(
       GURL("chrome://interstitials/safebrowsing?type=phishing"),
       "Security error");
@@ skipping 42 matching lines @@
 
   // Duplicate the tab and close it.
   chrome::DuplicateTab(browser());
   EXPECT_NE(current_tab, browser()->tab_strip_model()->active_index());
   chrome::CloseTab(browser());
   EXPECT_EQ(current_tab, browser()->tab_strip_model()->active_index());
 
   // Reloading the page shouldn't cause a crash.
   chrome::Reload(browser(), WindowOpenDisposition::CURRENT_TAB);
 }