include/core/SkReadBuffer.h - Issue 295793002: stop calling SkBitmap::flatten

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkReadBuffer.h

Issue 295793002: stop calling SkBitmap::flatten (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/core/SkReadBuffer.h

diff --git a/include/core/SkReadBuffer.h b/include/core/SkReadBuffer.h

index dfd92eedc0c26d986585d85019af1b27191e2568..b0c1b6e5aea06625ebe50c2c34eedf0dda8cd4c8 100644

--- a/include/core/SkReadBuffer.h

+++ b/include/core/SkReadBuffer.h

@@ -134,7 +134,11 @@ public:

// helpers to get info about arrays and binary data

virtual uint32_t getArrayCount();

- virtual void readBitmap(SkBitmap* bitmap);

+ /**

+ * Returns false if the bitmap could not be completely read. In that case, it will be set

+ * to have width/height, but no pixels.

+ */

+ virtual bool readBitmap(SkBitmap* bitmap);

scroggo 2014/05/20 13:27:50 If SkValidatingBuffer no longer overrides this, do

reed1 2014/05/20 17:49:58 Done.

virtual SkTypeface* readTypeface();

void setBitmapStorage(SkBitmapHeapReader* bitmapStorage) {