Add gdb helper functions for creating a handle and using ToCString with RawObjects.

Add gdb helper functions for creating a handle and using ToCString with RawObjects.

Improves gdb debugging when Object::Handle() is optimized away.

Replace some intermediate static_libraries with source_sets to fix export issue.

R=regis@google.com, vegorov@google.com, zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/f1b7e8ed8cb035ec8c4a8eca3b6536d06e97f84f

[rmacnak, 2017-06-26 17:23:43]

rmacnak@google.com changed reviewers:
+ asiva@google.com, regis@google.com, vegorov@google.com, zra@google.com

[regis, 2017-06-26 17:27:37]

lgtm

[siva, 2017-06-26 20:19:05]

DBC

https://codereview.chromium.org/2957843002/diff/1/runtime/vm/gdb_helpers.cc
File runtime/vm/gdb_helpers.cc (right):

https://codereview.chromium.org/2957843002/diff/1/runtime/vm/gdb_helpers.cc#n...
runtime/vm/gdb_helpers.cc:36: DART_NOINLINE
Seems to have lost the comment
// Like _printCurrentStackTrace, but works in a NoSafepointScope.

maybe add a comment describing when this method should be used.

https://codereview.chromium.org/2957843002/diff/1/runtime/vm/gdb_helpers.cc#n...
runtime/vm/gdb_helpers.cc:75: 
Should this entire file be wrapped under #if !defined(PRODUCT) ... #endif

[Vyacheslav Egorov (Google), 2017-06-26 20:22:04]

LGTM

Maybe mention this helpers on 

http://go/dartvm-cookbook/debugging-with-gdb

?

[zra, 2017-06-26 20:31:24]

https://codereview.chromium.org/2957843002/diff/1/runtime/vm/gdb_helpers.cc
File runtime/vm/gdb_helpers.cc (right):

https://codereview.chromium.org/2957843002/diff/1/runtime/vm/gdb_helpers.cc#n...
runtime/vm/gdb_helpers.cc:75: 
On 2017/06/26 20:19:05, siva wrote:
> Should this entire file be wrapped under #if !defined(PRODUCT) ... #endif

+1

[rmacnak, 2017-06-28 00:03:00]

Strangely these functions don't end up in the final binary, getting lost somehow
between libdart_vm_jit.a and libdart_jit.a

https://codereview.chromium.org/2957843002/diff/1/runtime/vm/gdb_helpers.cc
File runtime/vm/gdb_helpers.cc (right):

https://codereview.chromium.org/2957843002/diff/1/runtime/vm/gdb_helpers.cc#n...
runtime/vm/gdb_helpers.cc:36: DART_NOINLINE
On 2017/06/26 20:19:05, siva wrote:
> Seems to have lost the comment
> // Like _printCurrentStackTrace, but works in a NoSafepointScope.
> 
> maybe add a comment describing when this method should be used.

Done.

https://codereview.chromium.org/2957843002/diff/1/runtime/vm/gdb_helpers.cc#n...
runtime/vm/gdb_helpers.cc:75: 
On 2017/06/26 20:31:23, zra wrote:
> On 2017/06/26 20:19:05, siva wrote:
> > Should this entire file be wrapped under #if !defined(PRODUCT) ... #endif
> 
> +1

Done.

[rmacnak, 2017-06-29 20:33:19]

Description was changed from

==========
Add gdb helper functions for creating a handle and using ToCString with
RawObjects.

Improves gdb debugging when Object::Handle() is optimized away.
==========

to

==========
Add gdb helper functions for creating a handle and using ToCString with
RawObjects.

Improves gdb debugging when Object::Handle() is optimized away.

Replace some intermediate static_libraries with source_sets to fix export issue.
==========

[rmacnak, 2017-06-29 20:44:22]

Changed some static_libraries to source_sets in the GN to get the exported-ness
of these helpers to carry through properly. Doesn't seem to otherwise affect
binary size.

stripped dart binary
10635256 -> 10635272

[zra, 2017-06-29 21:06:12]

https://codereview.chromium.org/2957843002/diff/40001/runtime/vm/gdb_helpers.cc
File runtime/vm/gdb_helpers.cc (right):

https://codereview.chromium.org/2957843002/diff/40001/runtime/vm/gdb_helpers....
runtime/vm/gdb_helpers.cc:8: #include "lib/stacktrace.h"
Alphabetize includes

https://codereview.chromium.org/2957843002/diff/60001/runtime/vm/gdb_helpers.cc
File runtime/vm/gdb_helpers.cc (right):

https://codereview.chromium.org/2957843002/diff/60001/runtime/vm/gdb_helpers....
runtime/vm/gdb_helpers.cc:15: void _printRawObject(RawObject* object) {
Can we use namespaces or an AllStatic class to avoid _theStrangeNames here and
below?

[rmacnak, 2017-06-29 21:19:00]

https://codereview.chromium.org/2957843002/diff/40001/runtime/vm/gdb_helpers.cc
File runtime/vm/gdb_helpers.cc (right):

https://codereview.chromium.org/2957843002/diff/40001/runtime/vm/gdb_helpers....
runtime/vm/gdb_helpers.cc:8: #include "lib/stacktrace.h"
On 2017/06/29 21:06:11, zra wrote:
> Alphabetize includes

Done.

https://codereview.chromium.org/2957843002/diff/60001/runtime/vm/gdb_helpers.cc
File runtime/vm/gdb_helpers.cc (right):

https://codereview.chromium.org/2957843002/diff/60001/runtime/vm/gdb_helpers....
runtime/vm/gdb_helpers.cc:15: void _printRawObject(RawObject* object) {
On 2017/06/29 21:06:12, zra wrote:
> Can we use namespaces or an AllStatic class to avoid _theStrangeNames here and
> below?

Putting these in a class interfers with the export, which puts them in the
global namespace.

[zra, 2017-06-29 21:28:01]

lgtm

[rmacnak, 2017-06-29 21:31:49]

Description was changed from

==========
Add gdb helper functions for creating a handle and using ToCString with
RawObjects.

Improves gdb debugging when Object::Handle() is optimized away.

Replace some intermediate static_libraries with source_sets to fix export issue.
==========

to

==========
Add gdb helper functions for creating a handle and using ToCString with
RawObjects.

Improves gdb debugging when Object::Handle() is optimized away.

Replace some intermediate static_libraries with source_sets to fix export issue.

R=regis@google.com, vegorov@google.com, zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f1b7e8ed8cb035ec8c4a8eca3b6536d06e97f84f
==========

[rmacnak, 2017-06-29 21:31:51]

Committed patchset #5 (id:80001) manually as
f1b7e8ed8cb035ec8c4a8eca3b6536d06e97f84f (presubmit successful).