third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp - Issue 2957833004: Make VisiblePosition::LastPositionInNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

Issue 2957833004: Make VisiblePosition::LastPositionInNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-27T15:28:02 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/IndentOutdentCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

index 556169704b10b073771b8df683caaaa57e727a0b..48a1ae2f4b6aa655312f6b526a3daff2b294ac80 100644

--- a/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

@@ -50,7 +50,7 @@ static bool IsTableCellEmpty(Node* cell) {

DCHECK(cell);

DCHECK(IsTableCell(cell)) << cell;

return VisiblePosition::FirstPositionInNode(*cell).DeepEquivalent() ==

- VisiblePosition::LastPositionInNode(cell).DeepEquivalent();

+ VisiblePosition::LastPositionInNode(*cell).DeepEquivalent();

}

static bool IsTableRowEmpty(Node* row) {

@@ -520,7 +520,7 @@ void DeleteSelectionCommand::RemoveNode(

}

if (node == end_block_) {

VisiblePosition next =

- NextPositionOf(VisiblePosition::LastPositionInNode(end_block_.Get()));

+ NextPositionOf(VisiblePosition::LastPositionInNode(*end_block_.Get()));

if (next.IsNotNull() && !IsStartOfBlock(next))

need_placeholder_ = true;

}