third_party/WebKit/Source/core/editing/VisiblePosition.cpp - Issue 2957833004: Make VisiblePosition::LastPositionInNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisiblePosition.cpp

Issue 2957833004: Make VisiblePosition::LastPositionInNode() to take const Node& instead of Node* (Closed)

Patch Set: 2017-06-27T15:28:02 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/VisiblePosition.cpp

diff --git a/third_party/WebKit/Source/core/editing/VisiblePosition.cpp b/third_party/WebKit/Source/core/editing/VisiblePosition.cpp

index 69a691bfd271c8cd9e2dd22ea4ddcccddecf902c..63449132715cad4c26da7669dcd65f6958e7e00f 100644

--- a/third_party/WebKit/Source/core/editing/VisiblePosition.cpp

+++ b/third_party/WebKit/Source/core/editing/VisiblePosition.cpp

@@ -137,9 +137,9 @@ VisiblePositionTemplate<Strategy>::InParentBeforeNode(const Node& node) {

template <typename Strategy>

VisiblePositionTemplate<Strategy>

-VisiblePositionTemplate<Strategy>::LastPositionInNode(Node* node) {

+VisiblePositionTemplate<Strategy>::LastPositionInNode(const Node& node) {

return Create(PositionWithAffinityTemplate<Strategy>(

- PositionTemplate<Strategy>::LastPositionInNode(*node)));

+ PositionTemplate<Strategy>::LastPositionInNode(node)));

}

VisiblePosition CreateVisiblePosition(const Position& position,