Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Unified Diff: content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc

Issue 2957783002: Fix wrong ui::PAGE_TRANSITION_FORWARD_BACK in tests. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc
diff --git a/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc b/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc
index 78c5e8bea4bc188d58d7b029fed2889bf1b94f5a..02fc3bc43b45b1082f360334a1db9e15ba74df8b 100644
--- a/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc
+++ b/content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc
@@ -398,8 +398,9 @@ TEST_F(OverscrollNavigationOverlayTest, CancelAfterSuccessfulNavigation) {
EXPECT_TRUE(contents()->CrossProcessNavigationPending());
NavigationEntry* pending = contents()->GetController().GetPendingEntry();
- contents()->GetPendingMainFrame()->SendNavigate(
- pending->GetUniqueID(), false, pending->GetURL());
+ contents()->GetPendingMainFrame()->SendNavigateWithTransition(
+ pending->GetUniqueID(), false, pending->GetURL(),
+ pending->GetTransitionType());
EXPECT_EQ(contents()->GetURL(), third());
}
@@ -414,8 +415,9 @@ TEST_F(OverscrollNavigationOverlayTest, Navigation_PaintUpdate) {
EXPECT_TRUE(GetOverlay()->web_contents());
NavigationEntry* pending = contents()->GetController().GetPendingEntry();
- contents()->GetPendingMainFrame()->SendNavigate(
- pending->GetUniqueID(), false, pending->GetURL());
+ contents()->GetPendingMainFrame()->SendNavigateWithTransition(
+ pending->GetUniqueID(), false, pending->GetURL(),
+ pending->GetTransitionType());
ReceivePaintUpdate();
// Navigation was committed and the paint update was received - we should no

Powered by Google App Engine
This is Rietveld 408576698