third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h - Issue 2957733002: Only call TextChanged on existing AXObjects. This avoids triggering the code which calls UpdateDist…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h

Issue 2957733002: Only call TextChanged on existing AXObjects. This avoids triggering the code which calls UpdateDist… (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h

diff --git a/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h b/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h

index 0f710320be55be5f717d9f8e2e6ce914ba954322..d442109ea6a8dfe0d2e91dfe886b71969db19894 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h

+++ b/third_party/WebKit/Source/modules/accessibility/AXMenuListPopup.h

@@ -45,7 +45,7 @@ class AXMenuListPopup final : public AXMockObject {

bool IsEnabled() const override;

bool IsOffScreen() const override;

- void DidUpdateActiveOption(int option_index);

+ void DidUpdateActiveOption(int option_index, bool fire_notifications = true);

void DidShow();

void DidHide();

AXObjectImpl* ActiveDescendant() final;