Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 295773002: Mojo: Mojom: Make specialized handle types (e.g., message_pipe) not keywords. (Closed)

Created:
6 years, 7 months ago by viettrungluu
Modified:
6 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Mojo: Mojom: Make specialized handle types (e.g., message_pipe) not keywords. Other types (e.g., int32) aren't keywords, so it's a bit anomalous that the specialized handle types are. (Insisting that they be keywords makes adding future handle types more difficult, since doing so could break existing .mojom files.) R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271519

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -23 lines) Patch
M mojo/public/tools/bindings/pylib/mojom/parse/lexer.py View 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/parser.py View 1 1 chunk +17 lines, -12 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom_tests/parse/lexer_unittest.py View 1 chunk +0 lines, -6 lines 0 comments Download
M mojo/public/tools/bindings/pylib/mojom_tests/parse/parser_unittest.py View 2 chunks +42 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
viettrungluu
6 years, 7 months ago (2014-05-19 21:00:18 UTC) #1
darin (slow to review)
LGTM https://codereview.chromium.org/295773002/diff/1/mojo/public/tools/bindings/pylib/mojom/parse/parser.py File mojo/public/tools/bindings/pylib/mojom/parse/parser.py (right): https://codereview.chromium.org/295773002/diff/1/mojo/public/tools/bindings/pylib/mojom/parse/parser.py#newcode205 mojo/public/tools/bindings/pylib/mojom/parse/parser.py:205: if p[3] not in ('data_pipe_consumer', 'data_pipe_producer', nit: you ...
6 years, 7 months ago (2014-05-19 21:14:33 UTC) #2
viettrungluu
Thanks. https://codereview.chromium.org/295773002/diff/1/mojo/public/tools/bindings/pylib/mojom/parse/parser.py File mojo/public/tools/bindings/pylib/mojom/parse/parser.py (right): https://codereview.chromium.org/295773002/diff/1/mojo/public/tools/bindings/pylib/mojom/parse/parser.py#newcode205 mojo/public/tools/bindings/pylib/mojom/parse/parser.py:205: if p[3] not in ('data_pipe_consumer', 'data_pipe_producer', On 2014/05/19 ...
6 years, 7 months ago (2014-05-19 21:22:34 UTC) #3
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 7 months ago (2014-05-19 21:22:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/295773002/10001
6 years, 7 months ago (2014-05-19 21:23:20 UTC) #5
viettrungluu
6 years, 7 months ago (2014-05-20 00:03:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r271519 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698