Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Issue 2957703002: Refactor dependency_graph.dart. (Closed)

Created:
3 years, 6 months ago by Bob Nystrom
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Refactor dependency_graph.dart. It multiplexed a bunch of different events onto a single stream. But every single listener on that stream immediately demuxed them and only cared about a subset of the events. So I made separate streams for each event. Other minor clean-ups too. R=sigmund@google.com, whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/82df163eca1f025cdfe2169029d64a30432e80bb

Patch Set 1 #

Patch Set 2 : Merge branch 'master' into refactor-graph #

Patch Set 3 : Update dependency graph test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+210 lines, -223 lines) Patch
M tests/standalone/io/dependency_graph_test.dart View 1 2 2 chunks +27 lines, -20 lines 0 comments Download
M tools/testing/dart/dependency_graph.dart View 1 2 3 chunks +75 lines, -74 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 17 chunks +108 lines, -129 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Bob Nystrom
3 years, 6 months ago (2017-06-23 23:56:16 UTC) #2
Bill Hesse
3 years, 5 months ago (2017-06-26 14:40:08 UTC) #3
Bill Hesse
lgtm
3 years, 5 months ago (2017-06-26 14:40:16 UTC) #4
Bob Nystrom
Siggy, I forgot to fix the test when I refactored this. Would you mind reviewing ...
3 years, 5 months ago (2017-06-26 23:42:26 UTC) #6
Siggi Cherem (dart-lang)
lgtm
3 years, 5 months ago (2017-06-26 23:49:29 UTC) #7
Bob Nystrom
3 years, 5 months ago (2017-06-27 00:07:41 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
82df163eca1f025cdfe2169029d64a30432e80bb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698