Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2957643002: Remove the unused operations queue (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 5 months ago
Reviewers:
devoncarew, scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1256 lines) Patch
M pkg/analysis_server/lib/plugin/analysis/analysis_domain.dart View 2 chunks +1 line, -12 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 15 chunks +2 lines, -257 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 2 chunks +0 lines, -16 lines 0 comments Download
D pkg/analysis_server/lib/src/operation/operation.dart View 1 chunk +0 lines, -95 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 5 chunks +0 lines, -382 lines 0 comments Download
D pkg/analysis_server/lib/src/operation/operation_queue.dart View 1 chunk +0 lines, -137 lines 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 3 chunks +0 lines, -14 lines 0 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/update_content_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 4 chunks +8 lines, -35 lines 0 comments Download
M pkg/analysis_server/test/mocks.dart View 2 chunks +0 lines, -21 lines 0 comments Download
D pkg/analysis_server/test/operation/operation_queue_test.dart View 1 chunk +0 lines, -250 lines 0 comments Download
D pkg/analysis_server/test/operation/operation_test.dart View 1 chunk +0 lines, -14 lines 0 comments Download
D pkg/analysis_server/test/operation/test_all.dart View 1 chunk +0 lines, -18 lines 0 comments Download
M pkg/analysis_server/test/test_all.dart View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
3 years, 6 months ago (2017-06-23 14:52:17 UTC) #2
devoncarew
lgtm
3 years, 6 months ago (2017-06-23 15:48:36 UTC) #3
Brian Wilkerson
Committed patchset #1 (id:1) manually as 55d735911b3d603d1aac6a7dc75ca172890c4747 (presubmit successful).
3 years, 6 months ago (2017-06-23 16:04:18 UTC) #5
scheglov
3 years, 5 months ago (2017-06-26 16:02:06 UTC) #6
Message was sent while issue was closed.
LGTM!

Powered by Google App Engine
This is Rietveld 408576698